chore: Add a missing TypeScript stack to integration test #306
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lym953
commented
Oct 8, 2024
Comment on lines
+5
to
+7
| # aws-vault exec sso-serverless-sandbox-account-admin -- ./scripts/run_integration_tests.sh | ||
| # To regenerate snapshots: | ||
| # UPDATE_SNAPSHOTS=true aws-vault exec serverless-sandbox-account-admin -- ./scripts/run_integration_tests.sh | ||
| # UPDATE_SNAPSHOTS=true aws-vault exec sso-serverless-sandbox-account-admin -- ./scripts/run_integration_tests.sh |
There was a problem hiding this comment.
Fixing the wrong commands in doc
lym953
force-pushed
the
yiming.luo/python-stack-test-2
branch
from
cd25993 to
11b23f2
Compare
purple4reina
approved these changes
Oct 8, 2024
lym953
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Background
run_integration_tests.shrunscdk synthon a few example stacks, then compares the result with snapshots generated before, to check if a PR causes unexpected changes on the stack to be deployed.Motivation
Right now the test script uses 8 example stacks. A stack
lambda-function-stack-legacy-datadog-api.tswas added in #285, but it's not set up correctly to be used by the test script.What does this PR do?
Make
run_integration_tests.shcover the new stack as well.Testing Guidelines
aws-vault exec sso-serverless-sandbox-account-admin -- scripts/run_integration_tests.shruns successfully.Additional Notes
Types of Changes
Check all that apply