chore: Add integration test for Python stack #307
Conversation
lym953
changed the title
![datadog-datadog-prod-us1[bot]](https://avatars.githubusercontent.com/u/365230?s=60&v=4){kind=small}
| ' dotnet tool install -g Amazon.Lambda.Tools' + | ||
| ' && dotnet build' + | ||
| ' && dotnet lambda package --output-package /asset-output/function.zip' |
There was a problem hiding this comment.
🟠 Code Quality Violation
use f-string or .format to format strings (...read more)
Concatenation of multiple strings is not efficient and make the code hard to read and understand.
Instead of concatenating multiple strings, use an f-string or a format string.
Learn More
There was a problem hiding this comment.
Is this file suppose to be empty?
There was a problem hiding this comment.
Is this file suppose to be empty?
There was a problem hiding this comment.
Oh, tests are failing. Let me normalize DD_TAGS in the json.
lym953
force-pushed
the
yiming.luo/python-stack-test-3
branch
3 times, most recently
from
35b6f5e to
6557fe3
Compare
There was a problem hiding this comment.
Does it seem weird to you that these integration_tests/snapshots/test-* files are committed to git? Seems like they're overwritten by the test runner anyway.
There was a problem hiding this comment.
Good point. I'm already working on that. Coming soon in the next PR!
lym953
force-pushed
the
yiming.luo/python-stack-test-3
branch
from
6557fe3 to
2f9c536
Compare
What does this PR do?
Add a Python stack to integration tests, so that the test will compare the snapshots generated after vs before, to check if a PR causes unexpected changes on the stack to be deployed.
The stack was copied from
examples/python-stack. I had to copy it because I was unable to find a way to just reference the existing stack.Motivation
Adding more tests to make it safer to deploy changes.
Testing Guidelines
Additional Notes
Types of Changes
Check all that apply