Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Change CDK version from 2.134.0 to 2.146.0 #349

Merged
merged 1 commit into from
Dec 6, 2024

Conversation

lym953
Copy link
Contributor

@lym953 lym953 commented Dec 6, 2024

What does this PR do?

The cdkVersion parameter of a CDK construct is the

Minimum version of the AWS CDK to depend on.

(link)

This PR changes it from 2.134.0 to 2.146.0.

Motivation

To test our handling of a function determineLatestNodeRuntime() added in v2.146.0.

This is only used for tests. We don't use any feature of 2.146.0 in non-test code.

Testing Guidelines

Since the synthesized json file for Python Lambda and Step Function stacks are changed, I deployed the example Python stacks for Lambda and Step Function. Deployment was successful.

Additional Notes

Types of Changes

  • Bug fix
  • New feature
  • Breaking change
  • Misc (docs, refactoring, dependency upgrade, etc.)

Check all that apply

  • This PR's description is comprehensive
  • This PR contains breaking changes that are documented in the description
  • This PR introduces new APIs or parameters that are documented and unlikely to change in the foreseeable future
  • This PR impacts documentation, and it has been updated (or a ticket has been logged)
  • This PR's changes are covered by the automated tests
  • This PR collects user input/sensitive content into Datadog

@lym953 lym953 force-pushed the yiming.luo/aws-cdk-v146 branch from 888be3e to 848f191 Compare December 6, 2024 21:23
@lym953 lym953 marked this pull request as ready for review December 6, 2024 21:32
@lym953 lym953 requested a review from a team as a code owner December 6, 2024 21:32
@lym953
Copy link
Contributor Author

lym953 commented Dec 6, 2024

/merge

@dd-devflow
Copy link

dd-devflow bot commented Dec 6, 2024

Devflow running: /merge

View all feedbacks in Devflow UI.


2024-12-06 21:48:06 UTC ℹ️ MergeQueue: pull request added to the queue

The median merge time in main is 9m.

@dd-mergequeue dd-mergequeue bot merged commit 353f1f2 into main Dec 6, 2024
15 checks passed
@dd-mergequeue dd-mergequeue bot deleted the yiming.luo/aws-cdk-v146 branch December 6, 2024 21:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants