TestVisibility::Transport: rename env parameter to dd_env

DataDog · Oct 17, 2023 · 06670df · 06670df
1 parent a95abb7
commit 06670df
Show file tree

Hide file tree

Showing 3 changed files with 13 additions and 13 deletions.
diff --git a/lib/datadog/ci/test_visibility/transport.rb b/lib/datadog/ci/test_visibility/transport.rb
@@ -23,19 +23,19 @@ class Transport
           :api_key,
           :max_payload_size,
           :http,
-          :env
+          :dd_env
 
         def initialize(
           api_key:,
           url:,
-          env: nil,
+          dd_env: nil,
           serializers_factory: Datadog::CI::TestVisibility::Serializers::Factories::TestLevel,
           max_payload_size: DEFAULT_MAX_PAYLOAD_SIZE
         )
           @serializers_factory = serializers_factory
           @api_key = api_key
           @max_payload_size = max_payload_size
-          @env = env
+          @dd_env = dd_env
 
           uri = URI.parse(url)
 
@@ -141,12 +141,12 @@ def pack_events(encoded_events)
           packer.write_map_header(1)
 
           packer.write("*")
-          metadata_fields_count = env ? 4 : 3
+          metadata_fields_count = dd_env ? 4 : 3
           packer.write_map_header(metadata_fields_count)
 
-          if env
+          if dd_env
             packer.write("env")
-            packer.write(env)
+            packer.write(dd_env)
           end
 
           packer.write("runtime-id")

diff --git a/sig/datadog/ci/test_visibility/transport.rbs b/sig/datadog/ci/test_visibility/transport.rbs
@@ -6,20 +6,20 @@ module Datadog
 
         attr_reader serializers_factory: singleton(Datadog::CI::TestVisibility::Serializers::Factories::TestLevel)
         attr_reader api_key: String
-        attr_reader env: String?
+        attr_reader dd_env: String?
         attr_reader http: Datadog::CI::Transport::HTTP
         attr_reader max_payload_size: Integer
 
         @api_key: String
-        @env: String?
+        @dd_env: String?
         @http: Datadog::CI::Transport::HTTP
         @serializers_factory: singleton(Datadog::CI::TestVisibility::Serializers::Factories::TestLevel)
         @max_payload_size: Integer
 
         def initialize: (
           api_key: String,
           url: ::String,
-          ?env: ::String?,
+          ?dd_env: ::String?,
           ?serializers_factory: singleton(Datadog::CI::TestVisibility::Serializers::Factories::TestLevel),
           ?max_payload_size: Integer
         ) -> void

diff --git a/spec/datadog/ci/test_visibility/transport_spec.rb b/spec/datadog/ci/test_visibility/transport_spec.rb
@@ -8,15 +8,15 @@
   subject do
     described_class.new(
       api_key: api_key,
-      env: env,
+      dd_env: dd_env,
       url: url,
       serializers_factory: serializers_factory,
       max_payload_size: max_payload_size
     )
   end
 
   let(:api_key) { "api_key" }
-  let(:env) { nil }
+  let(:dd_env) { nil }
   let(:url) { "https://citestcycle-intake.datad0ghq.com:443" }
   let(:serializers_factory) { Datadog::CI::TestVisibility::Serializers::Factories::TestLevel }
   let(:max_payload_size) { 4 * 1024 * 1024 }
@@ -62,8 +62,8 @@
       end
     end
 
-    context "with env defined" do
-      let(:env) { "ci" }
+    context "with dd_env defined" do
+      let(:dd_env) { "ci" }
       before do
         produce_test_trace
       end