update rbs to 3.2 and enable typechecking for Gzip module

DataDog · Oct 16, 2023 · 0bb2377 · 0bb2377
1 parent f0c8ebe
commit 0bb2377
Show file tree

Hide file tree

Showing 3 changed files with 7 additions and 5 deletions.
diff --git a/Gemfile b/Gemfile
@@ -31,8 +31,8 @@ gem "simplecov-cobertura", "~> 2.1.0"
 
 # type checking
 group :check do
-  if RUBY_PLATFORM != "java"
-    gem "rbs", "~> 3.1.0", require: false
+  if RUBY_VERSION >= "3.0.0" && RUBY_PLATFORM != "java"
+    gem "rbs", "~> 3.2.0", require: false
     gem "steep", "~> 1.4.0", require: false
   end
 end
diff --git a/Steepfile b/Steepfile
@@ -4,14 +4,14 @@ target :lib do
   check "lib"
 
   ignore "lib/datadog/ci/configuration/settings.rb"
-  ignore "lib/datadog/ci/transport/gzip.rb"
 
   library "pathname"
   library "json"
   library "logger"
   library "date"
   library "minitest"
   library "net-http"
+  library "zlib"
 
   repo_path "vendor/rbs"
   library "ddtrace"

diff --git a/lib/datadog/ci/transport/gzip.rb b/lib/datadog/ci/transport/gzip.rb
@@ -10,9 +10,11 @@ module Gzip
         module_function
 
         def compress(input)
-          gzip_writer = Zlib::GzipWriter.new(StringIO.new)
+          sio = StringIO.new
+          gzip_writer = Zlib::GzipWriter.new(sio, Zlib::DEFAULT_COMPRESSION, Zlib::DEFAULT_STRATEGY)
           gzip_writer << input
-          gzip_writer.close.string
+          gzip_writer.close
+          sio.string
         end
       end
     end