Transport::Api::Base accepts HTTP client in intializer

DataDog · Oct 24, 2023 · 52b3a07 · 52b3a07
1 parent 2bfd58e
commit 52b3a07
Show file tree

Hide file tree

Showing 4 changed files with 21 additions and 11 deletions.
diff --git a/lib/datadog/ci/transport/api/base.rb b/lib/datadog/ci/transport/api/base.rb
@@ -7,6 +7,10 @@ module Api
         class Base
           attr_reader :http
 
+          def initialize(http:)
+            @http = http
+          end
+
           def request(path:, payload:, verb: "post")
             http.request(
               path: path,

diff --git a/lib/datadog/ci/transport/api/ci_test_cycle.rb b/lib/datadog/ci/transport/api/ci_test_cycle.rb
@@ -16,11 +16,13 @@ def initialize(api_key:, url:)
             uri = URI.parse(url)
             raise "Invalid agentless mode URL: #{url}" if uri.host.nil?
 
-            @http = Datadog::CI::Transport::HTTP.new(
-              host: uri.host,
-              port: uri.port,
-              ssl: uri.scheme == "https" || uri.port == 443,
-              compress: true
+            super(
+              http: Datadog::CI::Transport::HTTP.new(
+                host: uri.host,
+                port: uri.port,
+                ssl: uri.scheme == "https" || uri.port == 443,
+                compress: true
+              )
             )
           end
 

diff --git a/lib/datadog/ci/transport/api/evp_proxy.rb b/lib/datadog/ci/transport/api/evp_proxy.rb
@@ -9,12 +9,14 @@ module Transport
       module Api
         class EvpProxy < Base
           def initialize(host:, port:, ssl:, timeout:)
-            @http = Datadog::CI::Transport::HTTP.new(
-              host: host,
-              port: port,
-              ssl: ssl,
-              timeout: timeout,
-              compress: false
+            super(
+              http: Datadog::CI::Transport::HTTP.new(
+                host: host,
+                port: port,
+                ssl: ssl,
+                timeout: timeout,
+                compress: false
+              )
             )
           end
 

diff --git a/sig/datadog/ci/transport/api/base.rbs b/sig/datadog/ci/transport/api/base.rbs
@@ -5,6 +5,8 @@ module Datadog
         class Base
           attr_reader http: Datadog::CI::Transport::HTTP
 
+          def initialize: (http: Datadog::CI::Transport::HTTP) -> void
+
           def request: (path: String, payload: String, ?verb: ::String) -> untyped
 
           private