Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

More minor cleanup #10

Merged
merged 2 commits into from
Aug 23, 2023
Merged

More minor cleanup #10

merged 2 commits into from
Aug 23, 2023

Conversation

TonyCTHsu
Copy link
Contributor

  1. Remove ruby versioning to generate appraisal groups
  2. Remove broken rspec and cucumber dependencies for task :main

@@ -23,7 +23,7 @@ end
desc "Run RSpec"
# rubocop:disable Metrics/BlockLength
namespace :spec do
task all: [:main, :cucumber, :rspec]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is a dependency for task :all that it should run tests for main, cucumber, and rspec

Maybe we would rather need to add minitest here?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ideally, it should include all those tasks.

However, those tasks can only been executed with proper dependencies installed (using Appraisal at this moment).

For example:
bundle exec rake spec:main
🔴 bundle exec rake spec:cucumber
bundle exec appraisal cucumber8 rake spec:cucumber

@anmarchenko anmarchenko merged commit fc1679f into main Aug 23, 2023
4 checks passed
@anmarchenko anmarchenko deleted the tonycthsus/cleanup branch September 6, 2023 08:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants