Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CIVIS-2892] citestcov transport to serialize and send code coverage events #148

Merged
merged 9 commits into from
Mar 25, 2024

Conversation

anmarchenko
Copy link
Member

@anmarchenko anmarchenko commented Mar 21, 2024

What does this PR do?

  • Adds citestcov_request method to Transport::Api::Base to send events to citestcov intake as multipart/form-data (via agent or agentless intake)
  • Adds Coverage::Event class that serializes itself to msgpack
  • Adds Coverage::Transport class that packages msgpack payload and sends it to the intake
  • Deduplicated code in Coverage::Transport and TestVisibility::Transport by introducing common ancestor EventPlatformTransport
  • Fixed regression caused by a breaking change in datadog gem v2.0 with Datadog::Core::Transport::HTTP::Adapters::Net initialization

How to test the change?
Unit tests are provided

@codecov-commenter
Copy link

codecov-commenter commented Mar 22, 2024

Codecov Report

Attention: Patch coverage is 99.63899% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 99.23%. Comparing base (61be62e) to head (4ffbcb5).

Files Patch % Lines
lib/datadog/ci/itr/coverage/transport.rb 98.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##              1.0     #148      +/-   ##
==========================================
+ Coverage   99.22%   99.23%   +0.01%     
==========================================
  Files         171      175       +4     
  Lines        7468     7730     +262     
  Branches      310      317       +7     
==========================================
+ Hits         7410     7671     +261     
- Misses         58       59       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@anmarchenko anmarchenko marked this pull request as ready for review March 22, 2024 15:01
@anmarchenko anmarchenko requested review from a team as code owners March 22, 2024 15:01
@anmarchenko anmarchenko merged commit ef9930c into 1.0 Mar 25, 2024
23 checks passed
@anmarchenko anmarchenko deleted the anmarchenko/citestcov_transport branch March 25, 2024 11:34
@anmarchenko anmarchenko added this to the 1.0 milestone Mar 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants