Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CIVIS-2938] Upload packfiles API client #153

Merged
merged 4 commits into from
Apr 9, 2024

Conversation

anmarchenko
Copy link
Member

@anmarchenko anmarchenko commented Apr 8, 2024

What does this PR do?
Adds Git::UploadPackfile class that is able to upload a single git packfile to Datadog's git API.

Makes minor changes to git_commits_rev_list and git_generate_packfiles methods to make them safer and prevent shell injections.

How to test the change?
Unit tests are provided, otherwise this functionality is not used yet

@codecov-commenter
Copy link

codecov-commenter commented Apr 8, 2024

Codecov Report

Attention: Patch coverage is 98.87640% with 1 line in your changes missing coverage. Please review.

Project coverage is 99.02%. Comparing base (e238a74) to head (40cd927).

Files with missing lines Patch % Lines
spec/datadog/ci/git/upload_packfile_spec.rb 97.50% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##              1.0     #153      +/-   ##
==========================================
- Coverage   99.05%   99.02%   -0.03%     
==========================================
  Files         184      186       +2     
  Lines        8341     8421      +80     
  Branches      346      352       +6     
==========================================
+ Hits         8262     8339      +77     
- Misses         79       82       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@anmarchenko anmarchenko marked this pull request as ready for review April 8, 2024 14:01
@anmarchenko anmarchenko requested review from a team as code owners April 8, 2024 14:01
@anmarchenko anmarchenko merged commit ef80446 into 1.0 Apr 9, 2024
23 checks passed
@anmarchenko anmarchenko deleted the anmarchenko/upload_packfiles_api branch April 9, 2024 08:02
@anmarchenko anmarchenko added this to the 1.0 milestone Apr 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants