-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[CIVIS-2934] Request skippable tests when configuring ITR #159
[CIVIS-2934] Request skippable tests when configuring ITR #159
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## 1.0 #159 +/- ##
=======================================
Coverage 99.05% 99.05%
=======================================
Files 195 195
Lines 8957 9032 +75
Branches 387 390 +3
=======================================
+ Hits 8872 8947 +75
Misses 85 85 ☔ View full report in Codecov by Sentry. |
…to use os.architecture instead of os.arch
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
(I did not actually have a comment.)
@romainkomorndatadog I will gradually add parameters support in the next PR where test skipping will actually happen |
What does this PR do?
os.version
tag for tests (ATTENTION: it will change all test fingerprints when 1.0 is released)How to test the change?
Tested locally using my sidekiq fork and unit tests are provided. For now it saves a set of skippable tests without actually skipping them: to do in the next PR.