Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CIVIS-2934] Request skippable tests when configuring ITR #159

Merged
merged 10 commits into from
Apr 17, 2024

Conversation

anmarchenko
Copy link
Member

@anmarchenko anmarchenko commented Apr 12, 2024

What does this PR do?

  • Adds an API client for fetching skippable tests from ITR backend and calls it when configuring ITR runner.
  • Adds os.version tag for tests (ATTENTION: it will change all test fingerprints when 1.0 is released)
  • Adds retries mechanism on network errors (unstable DNS resolution of DD staging host inspired me to do that)

How to test the change?
Tested locally using my sidekiq fork and unit tests are provided. For now it saves a set of skippable tests without actually skipping them: to do in the next PR.

@codecov-commenter
Copy link

codecov-commenter commented Apr 15, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.05%. Comparing base (9641d3a) to head (b0ea212).

Additional details and impacted files
@@           Coverage Diff           @@
##              1.0     #159   +/-   ##
=======================================
  Coverage   99.05%   99.05%           
=======================================
  Files         195      195           
  Lines        8957     9032   +75     
  Branches      387      390    +3     
=======================================
+ Hits         8872     8947   +75     
  Misses         85       85           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@anmarchenko anmarchenko marked this pull request as ready for review April 16, 2024 11:57
@anmarchenko anmarchenko requested review from a team as code owners April 16, 2024 11:57
Copy link

@romainkomorndatadog romainkomorndatadog left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(I did not actually have a comment.)

@anmarchenko
Copy link
Member Author

@romainkomorndatadog I will gradually add parameters support in the next PR where test skipping will actually happen

@anmarchenko anmarchenko merged commit 4f59bc7 into 1.0 Apr 17, 2024
23 checks passed
@anmarchenko anmarchenko deleted the anmarchenko/itr_runner_fetch_skippable_tests branch April 17, 2024 07:42
@anmarchenko anmarchenko added this to the 1.0 milestone Apr 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants