-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[CIVIS-9478] Knapsack Pro 7/RSpec 3 support #172
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #172 +/- ##
==========================================
- Coverage 98.98% 98.97% -0.02%
==========================================
Files 198 202 +4
Lines 9638 9726 +88
Branches 423 431 +8
==========================================
+ Hits 9540 9626 +86
- Misses 98 100 +2 ☔ View full report in Codecov by Sentry. |
@anmarchenko Previously, we had |
@pcothenet yes, drop force_test_level_visibility from now on - knapsack pro is supported now |
Does this also work for minitest? |
@connorshea I didn't test support for minitest with knapsack pro; but it might still work. Please try it and create an issue if it doesn't work. |
Closes #147
What does this PR do?
Adds instrumentation to
KnapsackPro::Runners::Queue::RSpecRunner
for knapsack_pro gem versions 7.0 and above. This makes sure that every knapsack_pro run is correctly reported to Datadog as a separate test session.Motivation
Multiple reports of Datadog dropping test spans when using knapsack_pro
How to test the change?
Unit tests are provided