Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SDTEST-116] Send event_created and event_finished metrics for internal telemetry #200

Merged
merged 8 commits into from
Jul 23, 2024

Conversation

anmarchenko
Copy link
Member

@anmarchenko anmarchenko commented Jul 17, 2024

What does this PR do?
Adds event_created and event_finished metrics. As this PR is already large, I will implement other metrics in subsequent PRs.

Also this PR:

  • only enables telemetry with Datadog Agent for now as agentless mode is not released yet in gem datadog
  • refactors domain model code
  • introduces telemetry helpers and constants
  • bumps datadog dependency to 2.2 as this is currently the oldest version with metrics support
  • adds minor changes to dev setup: run bundle in docker without bundler version, replace docker-compose command with docker compose command

How to test the change?
Tested by running test suite with staging settings, see (DD only) dashboard here.

image

@anmarchenko anmarchenko changed the title Telemetry [SDTEST-116] Telemetry start Jul 17, 2024
@codecov-commenter
Copy link

codecov-commenter commented Jul 17, 2024

Codecov Report

Attention: Patch coverage is 99.41973% with 3 lines in your changes missing coverage. Please review.

Project coverage is 98.88%. Comparing base (03910f2) to head (afd50da).

Files Patch % Lines
spec/datadog/ci/test_visibility/component_spec.rb 92.00% 2 Missing ⚠️
lib/datadog/ci/test_visibility/component.rb 98.63% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #200      +/-   ##
==========================================
+ Coverage   98.86%   98.88%   +0.01%     
==========================================
  Files         235      242       +7     
  Lines       10477    10837     +360     
  Branches      481      489       +8     
==========================================
+ Hits        10358    10716     +358     
- Misses        119      121       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@anmarchenko anmarchenko changed the title [SDTEST-116] Telemetry start [SDTEST-116] Send event_created and event_finished metrics for internal telemetry Jul 23, 2024
@anmarchenko anmarchenko marked this pull request as ready for review July 23, 2024 12:51
@anmarchenko anmarchenko requested review from a team as code owners July 23, 2024 12:51
@anmarchenko anmarchenko merged commit 3d14714 into main Jul 23, 2024
28 checks passed
@anmarchenko anmarchenko deleted the anmarchenko/telemetry_metrics branch July 23, 2024 13:26
@github-actions github-actions bot added this to the 1.3.0 milestone Jul 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants