[SDTEST-116] Implement manual_api_events metric #202
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## anmarchenko/telemetry_metrics_net_requests #202 +/- ##
===========================================================================
Coverage 98.84% 98.85%
===========================================================================
Files 247 247
Lines 11117 11175 +58
Branches 502 502
===========================================================================
+ Hits 10989 11047 +58
Misses 128 128 ☔ View full report in Codecov by Sentry. |
nikita-tkachenko-datadog
approved these changes
Jul 26, 2024
| @@ -70,7 +70,7 @@ def on_test_case_started(event) | |||
|
|
|||
| start_test_suite(test_suite_name) unless same_test_suite_as_current?(test_suite_name) | |||
|
|
|||
| test_span = CI.start_test( | |||
There was a problem hiding this comment.
I'm not sure what the difference is between start_test and trace_test (other than the &block parameter, which does not seem to be used here), is this change intentional?
There was a problem hiding this comment.
Yes, the start_test is a convenience method that does not take a code block. I implemented it for public API, but not for private API. Now because of telemetry I cannot use public API anymore, so no convenience for me :(
Base automatically changed from
anmarchenko/telemetry_metrics_net_requests
to
main
July 29, 2024 07:47
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Tracks manual_api_events metric when public API is used.
Internal instrumentations don't use public API anymore.
How to test the change?
Unit tests are provided