Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SDTEST-755] attempt to fix datadog_cov crash when doing allocation profiling #224

Merged
merged 2 commits into from
Aug 28, 2024

Conversation

anmarchenko
Copy link
Member

@anmarchenko anmarchenko commented Aug 27, 2024

What does this PR do?
Fixes potential crash from the test impact analysis native extension when Object.const_source_location unexpectedly returns weird values. Adds more testing for these cases.

Motivation
We got reports of datadog_cov native extension crashes via telemetry crashtracker: while the root cause is unknown yet, this fix is an attempt to mitigate one of the possible causes

How to test the change?
Unit tests are provided

…crashes by making sure that filename is a T_STRING when processing instantiated classes in allocation profiler
@codecov-commenter
Copy link

codecov-commenter commented Aug 27, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.93%. Comparing base (af3db96) to head (58452e4).
Report is 15 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #224   +/-   ##
=======================================
  Coverage   98.92%   98.93%           
=======================================
  Files         261      262    +1     
  Lines       12391    12440   +49     
  Branches      560      560           
=======================================
+ Hits        12258    12307   +49     
  Misses        133      133           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@anmarchenko anmarchenko marked this pull request as ready for review August 28, 2024 09:18
@anmarchenko anmarchenko requested review from a team as code owners August 28, 2024 09:18
@anmarchenko anmarchenko merged commit 12ed0e8 into main Aug 28, 2024
30 checks passed
@anmarchenko anmarchenko deleted the anmarchenko/fix_datadog_cov_crashes branch August 28, 2024 09:28
@github-actions github-actions bot added this to the 1.5.0 milestone Aug 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants