Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SDTEST-740] Minor telemetry fixes #226

Merged

Conversation

anmarchenko
Copy link
Member

@anmarchenko anmarchenko commented Aug 28, 2024

What does this PR do?

  • Sends code_coverage_is_empty telemetry metric only when code coverage is empty and test was not skipped
  • Adds additional unit tests for skipped tests metric

How to test the change?
Unit tests are provided

@codecov-commenter
Copy link

codecov-commenter commented Aug 28, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.93%. Comparing base (1da7397) to head (c82db0d).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #226   +/-   ##
=======================================
  Coverage   98.93%   98.93%           
=======================================
  Files         262      262           
  Lines       12440    12461   +21     
  Branches      560      560           
=======================================
+ Hits        12307    12328   +21     
  Misses        133      133           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@anmarchenko anmarchenko changed the title [SDTEST-740] Don't collect code coverage for retried tests [SDTEST-740] Minor telemetry fixes Aug 28, 2024
@anmarchenko anmarchenko merged commit c8cb890 into main Aug 28, 2024
30 checks passed
@anmarchenko anmarchenko deleted the anmarchenko/itr_fix_code_coverage_for_retries_and_telemetry branch August 28, 2024 12:48
@github-actions github-actions bot added this to the 1.5.1 milestone Aug 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants