Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add note to readme.md that right now this gem is part of ddtrace and not to be used on its own #23

Merged
merged 3 commits into from
Sep 8, 2023

Conversation

anmarchenko
Copy link
Member

What does this PR do?
Add a note to readme.md that right now this gem is part of ddtrace and not to be used on its own.

Motivation
When this gem becomes open-source it may cause confusion about which gem to use for Test Visibility in Ruby. I want to make it clear that right now ddtrace gem is to be used (but this will change in the next major release).

How to test the change?
Read the copy and tell me if it is clear.

@anmarchenko anmarchenko requested review from a team September 7, 2023 09:30
@anmarchenko anmarchenko added this to the 0.1.0 milestone Sep 8, 2023
Copy link
Member

@ivoanjo ivoanjo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Left a few suggestions, LGTM

README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
anmarchenko and others added 2 commits September 8, 2023 17:12
Co-authored-by: Ivo Anjo <ivo@ivoanjo.me>
Co-authored-by: Ivo Anjo <ivo@ivoanjo.me>
@anmarchenko anmarchenko merged commit 0fd1f89 into main Sep 8, 2023
5 checks passed
@anmarchenko anmarchenko deleted the anmarchenko/readme_that_gem_is_part_of_ddtrace branch September 8, 2023 15:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants