[SDTEST-528] Add pull_request extra tags for GitHub Actions #238
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #238 +/- ##
=======================================
Coverage 98.95% 98.95%
=======================================
Files 273 273
Lines 13381 13402 +21
Branches 601 604 +3
=======================================
+ Hits 13241 13262 +21
Misses 140 140
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
anmarchenko
commented
Sep 23, 2024
| @@ -967,7 +967,7 @@ def rspec_skipped_session_run | |||
| let(:integration_options) { {service_name: "lspec"} } | |||
| end | |||
|
|
|||
| it "retries test until it passes" do | |||
| it "does not report the test that failed when RSpec was quitting" do | |||
There was a problem hiding this comment.
This change is not relevant to this PR's topic, I just noticed that one of the specs was copy-pasted without changing description
anmarchenko
commented
Sep 23, 2024
| @@ -710,5 +710,70 @@ | |||
| "git.commit.sha": "b9f0fb3fdbb94c9d24b2c75b49663122a529e123", | |||
| "git.repository_url": "https://1.1.1.1:1234/ghactions-repo.git" | |||
| } | |||
| ], | |||
| [ | |||
There was a problem hiding this comment.
here are the actual test cases:
- happy path
- case where events file is not found
juan-fernandez
approved these changes
Sep 23, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Adds extra tags with Git metadata for Github Actions workflows that are triggered with pull_request event.
Motivation
In GHA pull_request workflows HEAD does not point to the last commit in the PR, but to a commit that is the result of merging PR branch with the target branch.
Datadog backend needs additional information in this case to correctly determine the latest commit in the PR branch.
How to test the change?
Unit tests are provided