[CIAPP-4278] Fix an issue with emojis in commit message breaking LocalGit tags provider #40
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ekump
approved these changes
Oct 2, 2023
|
Thanks for fixing this so I can litter commit messages with emoji again 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fixes an issue with emojis in git commit message.
Sometimes Ruby sets default external encoding to US_ASCII even thou LANG is "en_US.UTF-8". In these cases non-ASCII characters like emojis break LocalGit provider.
In order to mitigate that, I force UTF-8 encoding if external encoding is US-ASCII. It is safe to do as UTF-8 is backwards compatible with US-ASCII.
Motivation
Fixing bug report
How to test the change?
By running unit tests