Simplify appraisal gemfiles naming by dropping patch version #53
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
do not require ddagent for docker containers
Codecov Report
@@ Coverage Diff @@
## main #53 +/- ##
=======================================
Coverage 99.15% 99.15%
=======================================
Files 95 95
Lines 3324 3324
Branches 129 129
=======================================
Hits 3296 3296
Misses 28 28 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
romainkomorndatadog
approved these changes
Oct 19, 2023
anmarchenko
deleted the
anmarchenko/appraisals_drop_minor_ruby_version
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #39
What does this PR do?
Makes appraisal gemfiles simpler by not including patch ruby version in them. This will allow us to not generate them when minor version is changed.
Motivation
Improve developer experince