Ruby versions for CI visibility #8
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anmarchenko
force-pushed
the
anmarchenko/drop_ruby_26_support
branch
from
07f1038
to
145b324
Compare
TonyCTHsu
approved these changes
Aug 21, 2023
| @@ -236,6 +141,7 @@ volumes: | |||
| bundle-3.0: | |||
| bundle-3.1: | |||
| bundle-3.2: | |||
| bundle-3.3: | |||
There was a problem hiding this comment.
Some volumes for old rubies could be gone as well.
docker-compose.yml
Outdated
| @@ -236,6 +141,7 @@ volumes: | |||
| bundle-3.0: | |||
| bundle-3.1: | |||
| bundle-3.2: | |||
| bundle-3.3: | |||
| # ADD NEW RUBIES HERE | |||
| bundle-jruby-9.2: | |||
| bundle-jruby-9.3: | |||
There was a problem hiding this comment.
Probably worth checking those jrubies.
I think jruby-9.2.21.0 -> ruby 2.5.x, jruby-9.3.9.0 -> ruby 2.6.x and jruby:9.4.0.0 -> ruby 2.7.x.
There was a problem hiding this comment.
yes, jruby 9.4 is ruby 2.7+, so I guess I would need to replace 9.3 with 9.4 here
.standard_todo.yml
Outdated
| @@ -2,14 +2,6 @@ | |||
| # Remove from this list as you refactor files. | |||
| --- | |||
| ignore: | |||
| - lib/datadog/ci/contrib/minitest/integration.rb: | |||
There was a problem hiding this comment.
This could be a bit tricky during the migration. Where user is installing ddtrace with older rubies where safe operator could be a breaking change.
There was a problem hiding this comment.
true, given that we decided to invert dependency for now I need to keep this to make ddtrace-rb specs pass
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Dropped support for rubies older than 2.7 (including jruby 9.2).
Added tests that this gem works with Ruby 3.3 (rc).