-
Notifications
You must be signed in to change notification settings - Fork 55
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[SYNTH-16911] Trigger batch with LTDs #1494
Merged
Drarig29
merged 5 commits into
master
from
corentin.girard/SYNTH-16911/trigger-batch-with-LTDs
Nov 21, 2024
Merged
[SYNTH-16911] Trigger batch with LTDs #1494
Drarig29
merged 5 commits into
master
from
corentin.girard/SYNTH-16911/trigger-batch-with-LTDs
Nov 21, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Drarig29
force-pushed
the
corentin.girard/SYNTH-16911/trigger-batch-with-LTDs
branch
from
November 18, 2024 17:21
50ffa49
to
f4ca7d1
Compare
Datadog ReportBranch report: ✅ 0 Failed, 3489 Passed, 0 Skipped, 2m 24.69s Total duration (1m 15.02s time saved) |
etnbrd
reviewed
Nov 18, 2024
etnbrd
approved these changes
Nov 20, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks!
Left a couple of comments to improve the types.
Drarig29
deleted the
corentin.girard/SYNTH-16911/trigger-batch-with-LTDs
branch
November 21, 2024 14:45
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What and why?
This PR adds support for loading LTDs and sending them to the trigger endpoint.
How?
localTestDefinition
to.synthetics.json
filesReview checklist