Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SYNTH-16911] Trigger batch with LTDs #1494

Merged
merged 5 commits into from
Nov 21, 2024

Conversation

Drarig29
Copy link
Contributor

@Drarig29 Drarig29 commented Nov 18, 2024

What and why?

This PR adds support for loading LTDs and sending them to the trigger endpoint.

How?

  • Add localTestDefinition to .synthetics.json files

Review checklist

  • Feature or bugfix MUST have appropriate tests (unit, integration)

@Drarig29 Drarig29 added the synthetics Related to [synthetics] label Nov 18, 2024
@Drarig29 Drarig29 force-pushed the corentin.girard/SYNTH-16911/trigger-batch-with-LTDs branch from 50ffa49 to f4ca7d1 Compare November 18, 2024 17:21
@datadog-datadog-prod-us1
Copy link

datadog-datadog-prod-us1 bot commented Nov 18, 2024

Datadog Report

Branch report: corentin.girard/SYNTH-16911/trigger-batch-with-LTDs
Commit report: df554be
Test service: datadog-ci-tests

✅ 0 Failed, 3489 Passed, 0 Skipped, 2m 24.69s Total duration (1m 15.02s time saved)

@Drarig29 Drarig29 marked this pull request as ready for review November 18, 2024 17:52
@Drarig29 Drarig29 requested review from a team as code owners November 18, 2024 17:52
src/commands/synthetics/interfaces.ts Outdated Show resolved Hide resolved
src/commands/synthetics/interfaces.ts Outdated Show resolved Hide resolved
src/commands/synthetics/test.ts Outdated Show resolved Hide resolved
src/commands/synthetics/utils/public.ts Outdated Show resolved Hide resolved
src/commands/synthetics/utils/public.ts Outdated Show resolved Hide resolved
src/commands/synthetics/utils/public.ts Outdated Show resolved Hide resolved
@Drarig29 Drarig29 requested review from a team and etnbrd November 19, 2024 16:20
Copy link
Contributor

@etnbrd etnbrd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!
Left a couple of comments to improve the types.

src/commands/synthetics/utils/public.ts Show resolved Hide resolved
src/commands/synthetics/interfaces.ts Show resolved Hide resolved
src/commands/synthetics/interfaces.ts Outdated Show resolved Hide resolved
src/commands/synthetics/interfaces.ts Outdated Show resolved Hide resolved
@Drarig29 Drarig29 merged commit dcd26a6 into master Nov 21, 2024
18 checks passed
@Drarig29 Drarig29 deleted the corentin.girard/SYNTH-16911/trigger-batch-with-LTDs branch November 21, 2024 14:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
synthetics Related to [synthetics]
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants