Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix DD_TAGS format issues #135

Merged
merged 2 commits into from
Oct 19, 2022
Merged

Conversation

NouemanKHAL
Copy link
Member

This PR fixes an issue where DD_TAGS would appear as a single (long) tag.

Since the content of DD_TAGS is already extracted inside the get_tags.py script (line 42), and injected into the agent config file datadog.yaml.

We should reset the env var as it's also being picked by the agent, and might cause some bugs in the tags format.

@NouemanKHAL NouemanKHAL added the changelog/Fixed Fixed features results into a bug fix version bump label Sep 29, 2022
@NouemanKHAL NouemanKHAL requested a review from a team as a code owner September 29, 2022 12:26
@NouemanKHAL NouemanKHAL changed the title Fix DD_TAGS formatting issues Fix DD_TAGS format issues Sep 29, 2022
lib/run-datadog.sh Outdated Show resolved Hide resolved
Co-authored-by: Sarah Witt <sarah.witt@datadoghq.com>
@NouemanKHAL NouemanKHAL merged commit 5b6c279 into master Oct 19, 2022
@NouemanKHAL NouemanKHAL deleted the noueman/fix-comma-seperatad-tags branch October 19, 2022 15:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog/Fixed Fixed features results into a bug fix version bump
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants