Fix tag parsing in DCA tags injection #144
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NouemanKHAL
reviewed
Dec 1, 2022
NouemanKHAL
reviewed
Dec 3, 2022
NouemanKHAL
reviewed
Dec 3, 2022
NouemanKHAL
reviewed
Dec 3, 2022
NouemanKHAL
reviewed
Dec 3, 2022
NouemanKHAL
reviewed
Dec 3, 2022
NouemanKHAL
reviewed
Dec 3, 2022
NouemanKHAL
reviewed
Dec 5, 2022
NouemanKHAL
approved these changes
Dec 5, 2022
NouemanKHAL
added
the
changelog/Fixed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fixes tag parsing when tags have spaces in them when performing DCA tags injection
Additionally, cleans up some of the logic regarding logs config creation, and adds more log lines.
Description of the Change
Alternate Designs
Possible Drawbacks
Verification Process
Additional Notes
Release Notes
Review checklist (to be filled by reviewers)
changelog/label attached. If applicable it should have thebackward-incompatiblelabel attached.do-not-merge/label attached.kind/andseverity/labels attached at least.