-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix environment variables sharing #151
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NouemanKHAL
added
the
changelog/Fixed
Fixed features results into a bug fix version bump
label
Jan 11, 2023
sarah-witt
reviewed
Jan 11, 2023
sarah-witt
reviewed
Jan 11, 2023
sarah-witt
reviewed
Jan 11, 2023
Co-authored-by: Sarah Witt <sarah.witt@datadoghq.com>
Co-authored-by: Sarah Witt <sarah.witt@datadoghq.com>
NouemanKHAL
commented
Jan 12, 2023
sarah-witt
previously approved these changes
Jan 12, 2023
sarah-witt
previously approved these changes
Jan 25, 2023
sarah-witt
approved these changes
Jan 25, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
dash
orbash
.Description of the Change
Instead of using
export
andsource
to export all env vars and import them.We'll only export the env vars required by the datadog scripts using the function
dd_export_env
, and usesafe_source
to import them, which allows us to skip any failing ones if any instead of crashing the script.Review checklist (to be filled by reviewers)
changelog/
label attached. If applicable it should have thebackward-incompatible
label attached.do-not-merge/
label attached.kind/
andseverity/
labels attached at least.