Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix environment variables sharing #151

Merged
merged 11 commits into from
Jan 25, 2023
Merged

Conversation

NouemanKHAL
Copy link
Member

@NouemanKHAL NouemanKHAL commented Jan 11, 2023

What does this PR do?

  • Changes the way she share env variables between our scripts, fixing issues with env variables format that are unsupported by dash or bash.
  • Stops restarting the trace agent on CAPI metadata update.

Description of the Change

Instead of using export and source to export all env vars and import them.
We'll only export the env vars required by the datadog scripts using the function dd_export_env , and use safe_source to import them, which allows us to skip any failing ones if any instead of crashing the script.

Review checklist (to be filled by reviewers)

  • PR title must be written as a CHANGELOG entry (see why)
  • Files changes must correspond to the primary purpose of the PR as described in the title (small unrelated changes should have their own PR)
  • PR must have one changelog/ label attached. If applicable it should have the backward-incompatible label attached.
  • PR should not have do-not-merge/ label attached.
  • If Applicable, issue must have kind/ and severity/ labels attached at least.

@NouemanKHAL NouemanKHAL added the changelog/Fixed Fixed features results into a bug fix version bump label Jan 11, 2023
@NouemanKHAL NouemanKHAL requested a review from a team as a code owner January 11, 2023 17:59
lib/scripts/utils.sh Outdated Show resolved Hide resolved
bin/supply Outdated Show resolved Hide resolved
bin/compile Outdated Show resolved Hide resolved
lib/scripts/utils.sh Outdated Show resolved Hide resolved
sarah-witt
sarah-witt previously approved these changes Jan 12, 2023
sarah-witt
sarah-witt previously approved these changes Jan 25, 2023
@NouemanKHAL NouemanKHAL merged commit 6fb6588 into master Jan 25, 2023
@NouemanKHAL NouemanKHAL deleted the noueman/improve-env-vars-sharing branch January 25, 2023 19:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog/Fixed Fixed features results into a bug fix version bump
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants