Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Container tags detection in Traces when CAPI Metadata Collection is disabled #156

Merged
merged 2 commits into from
Feb 6, 2023

Conversation

sarah-witt
Copy link
Contributor

What does this PR do?

Always creates the node_agent_tags.txt to allow container/trace correlation, even when DD_ENABLE_CAPI_METADATA_COLLECTION is disabled

Description of the Change

Alternate Designs

Possible Drawbacks

Verification Process

Additional Notes

Release Notes

Review checklist (to be filled by reviewers)

  • PR title must be written as a CHANGELOG entry (see why)
  • Files changes must correspond to the primary purpose of the PR as described in the title (small unrelated changes should have their own PR)
  • PR must have one changelog/ label attached. If applicable it should have the backward-incompatible label attached.
  • PR should not have do-not-merge/ label attached.
  • If Applicable, issue must have kind/ and severity/ labels attached at least.

@sarah-witt sarah-witt added the changelog/Fixed Fixed features results into a bug fix version bump label Jan 27, 2023
@sarah-witt sarah-witt changed the title Always create node_agent_tags.txt Always create node_agent_tags.txt Jan 27, 2023
@sarah-witt sarah-witt marked this pull request as ready for review January 27, 2023 22:17
@sarah-witt sarah-witt requested a review from a team as a code owner January 27, 2023 22:17
@sarah-witt sarah-witt changed the title Always create node_agent_tags.txt Enable Container tags detection in Traces when CAPI Metadata Collection is disabled Feb 6, 2023
@sarah-witt sarah-witt changed the title Enable Container tags detection in Traces when CAPI Metadata Collection is disabled Fix Container tags detection in Traces when CAPI Metadata Collection is disabled Feb 6, 2023
@sarah-witt sarah-witt merged commit 63178c9 into master Feb 6, 2023
@sarah-witt sarah-witt deleted the sarah/always-create-node-agent-txt branch February 6, 2023 16:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog/Fixed Fixed features results into a bug fix version bump
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants