Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Automate Releases #450

Merged
merged 102 commits into from
Jan 23, 2024
Merged

chore: Automate Releases #450

merged 102 commits into from
Jan 23, 2024

Conversation

duncanista
Copy link
Contributor

@duncanista duncanista commented Dec 11, 2023

What does this PR do?

Adds GitLab pipeline and migrates current GitHub actions there.
Screenshot 2024-01-20 at 12 28 11 PM

Migrates:

  • Unit Tests
  • Integration Tests
  • Check Layer Size
  • Linting

Adds:

  • Build Layer
  • Sign Layer
  • Publish Layer (sandbox and prod)

Motivation

Automate Layer Releases.
SVLS-4265

Testing Guidelines

  • All test working as normal
  • Layers are deployed to both sandbox and prod

Additional Notes

  • Removed signing for sandbox layers (shown in this PRs picture)
  • GovCloud is still done manually.

Types of Changes

  • Bug fix
  • New feature
  • Breaking change
  • Misc (docs, refactoring, dependency upgrade, etc.)

Check all that apply

  • This PR's description is comprehensive
  • This PR contains breaking changes that are documented in the description
  • This PR introduces new APIs or parameters that are documented and unlikely to change in the foreseeable future
  • This PR impacts documentation, and it has been updated (or a ticket has been logged)
  • This PR's changes are covered by the automated tests
  • This PR collects user input/sensitive content into Datadog
  • This PR passes the integration tests (ask a Datadog member to run the tests)

@codecov-commenter
Copy link

codecov-commenter commented Dec 11, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (afc1a75) 82.11% compared to head (0b569de) 82.11%.

❗ Current head 0b569de differs from pull request most recent head 864e3f5. Consider uploading reports for the commit 864e3f5 to get more accurate results

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #450   +/-   ##
=======================================
  Coverage   82.11%   82.11%           
=======================================
  Files          54       54           
  Lines        2186     2186           
  Branches      509      509           
=======================================
  Hits         1795     1795           
  Misses        329      329           
  Partials       62       62           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@duncanista duncanista marked this pull request as ready for review January 20, 2024 17:34
@duncanista duncanista requested a review from a team as a code owner January 20, 2024 17:34
@duncanista duncanista changed the title add .gitlab-ci.yml chore: Automate Releases Jan 22, 2024
@@ -0,0 +1,177 @@
stages:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

❤️ this templating approach!

Copy link
Contributor

@joeyzhao2018 joeyzhao2018 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

❤️ and :shipit:

@@ -0,0 +1,29 @@
regions:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not needed for this PR: I think we probably want a way to remind us if there's a new region added.
Related to this PR: We need to catch up some of the regions before we enable the pipelines.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Correct, right now this approach wouldn't work for GovCloud either, since we are setting those regions here.

An ideal solution for another PR would be: in the generator pipeline, list regions and generate this file!

built layers after 1 hour and signed layers after 1 day
also added `needs` for NPM publishing in prod
ci/publish_layers.sh Outdated Show resolved Hide resolved
Copy link
Contributor

@astuyve astuyve left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀 🚀 🌔

@duncanista duncanista merged commit dab417e into main Jan 23, 2024
40 checks passed
@duncanista duncanista deleted the jordan.gonzalez/add-gitlab-ci branch January 23, 2024 21:55
@duncanista duncanista mentioned this pull request Jan 23, 2024
11 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants