fix: Duplicate Payload Object in Input from SFN #592
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![datadog-datadog-prod-us1[bot]](https://avatars.githubusercontent.com/u/365230?s=60&v=4){kind=small}
nhulston
reviewed
Nov 20, 2024
src/trace/step-function-service.ts
Outdated
Comment on lines
80
to
81
| typeof event.Payload === "object" && | ||
| (typeof event.Payload._datadog === "object" || this.isValidContextObject(event.Payload)) |
There was a problem hiding this comment.
Nit: We could make this safer by adding optional chaining, i.e.
typeof event?.Payload === "object".
Unless we already know for sure that event is defined, then we don't have to do this
nhulston
reviewed
Nov 20, 2024
Comment on lines
+207
to
+209
| execution_id: event.Execution.Id, | ||
| state_entered_time: event.State.EnteredTime, | ||
| state_name: event.State.Name, |
There was a problem hiding this comment.
same micro nit here, might be safer to do event?.Execution?.Id and so on
nhulston
reviewed
Nov 20, 2024
src/trace/step-function-service.ts
Outdated
Comment on lines
219
to
224
| typeof context.Execution === "object" && | ||
| typeof context.Execution.Id === "string" && | ||
| typeof context.State === "object" && | ||
| typeof context.State.EnteredTime === "string" && | ||
| typeof context.State.Name === "string" | ||
| ); |
There was a problem hiding this comment.
Same micro nit. Ignore me if you know 100% these fields always exist
nhulston
approved these changes
Nov 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Adds a guard clause around the code where we unpack the
Payloadobject if it exists in the Step Functions event. There's an edge case where it isn't a Legacy Lambda object but customer's data may have aPayloadin thereMotivation
Python layer already checks this, we forgot to add it for node
Testing Guidelines
Tested in staging, here's a sample trace that shows how this fixes the trace merging
Additional Notes
Types of Changes
Check all that apply