Move span pointer to inferred (root) span #552
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Waiting on #551 |
| @@ -1368,8 +1368,9 @@ def create_function_execution_span( | |||
| if parent_span: | |||
| span.parent_id = parent_span.span_id | |||
| if span_pointers: | |||
| root_span = parent_span if parent_span else span | |||
There was a problem hiding this comment.
nano-nit: is root_span the right name? should this be target_span or something?
There was a problem hiding this comment.
Could be either; I think root_span makes sense because in the case of S3, the parent_span is the root span if it exists; if it doesn't exist, then the span is the root span of the trace
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Put span pointers on inferred (root) span instead of the lambda (child) span, as discussed in Slack.
Note that moving the location of the span pointer has no actual effect on the functionality and requires no changes on the UI side. As long as a span is found with a matching hash, span pointers work. Since the spans are on the same trace, this has no noticeable change for our users.
Motivation
Discussed in Slack; this change just aligns span pointers with bottlecap (universally instrumented) runtimes.
Testing Guidelines
Manual testing. See this span and you will see that the span links are on the inferred span now.
Types of Changes
Check all that apply