service discovery: Add missing cgroup mount (#1610) (#1617)

* service discovery: Add missing cgroup mount Add a missing cgroup mount to system-probe which is required to get container information. * Update test Co-authored-by: Vincent Whitchurch <vincent.whitchurch@datadoghq.com>
DataDog · Jan 10, 2025 · 6f16970 · 6f16970
1 parent 1590012
commit 6f16970
Show file tree

Hide file tree

Showing 2 changed files with 18 additions and 0 deletions.
diff --git a/internal/controller/datadogagent/feature/servicediscovery/feature.go b/internal/controller/datadogagent/feature/servicediscovery/feature.go
@@ -71,6 +71,11 @@ func (f *serviceDiscoveryFeature) ManageNodeAgent(managers feature.PodTemplateMa
 	managers.VolumeMount().AddVolumeMountToContainer(&procdirMount, apicommon.SystemProbeContainerName)
 	managers.Volume().AddVolume(&procdirVol)
 
+	// Needed to resolve container information
+	cgroupsVol, cgroupsMount := volume.GetVolumes(v2alpha1.CgroupsVolumeName, v2alpha1.CgroupsHostPath, v2alpha1.CgroupsMountPath, true)
+	managers.VolumeMount().AddVolumeMountToContainer(&cgroupsMount, apicommon.SystemProbeContainerName)
+	managers.Volume().AddVolume(&cgroupsVol)
+
 	socketVol, socketVolMount := volume.GetVolumesEmptyDir(v2alpha1.SystemProbeSocketVolumeName, v2alpha1.SystemProbeSocketVolumePath, false)
 	managers.Volume().AddVolume(&socketVol)
 	managers.VolumeMount().AddVolumeMountToContainer(&socketVolMount, apicommon.SystemProbeContainerName)

diff --git a/internal/controller/datadogagent/feature/servicediscovery/feature_test.go b/internal/controller/datadogagent/feature/servicediscovery/feature_test.go
@@ -63,6 +63,11 @@ func Test_serviceDiscoveryFeature_Configure(t *testing.T) {
 				MountPath: v2alpha1.ProcdirMountPath,
 				ReadOnly:  true,
 			},
+			{
+				Name:      v2alpha1.CgroupsVolumeName,
+				MountPath: v2alpha1.CgroupsMountPath,
+				ReadOnly:  true,
+			},
 			{
 				Name:      v2alpha1.SystemProbeSocketVolumeName,
 				MountPath: v2alpha1.SystemProbeSocketVolumePath,
@@ -86,6 +91,14 @@ func Test_serviceDiscoveryFeature_Configure(t *testing.T) {
 					},
 				},
 			},
+			{
+				Name: v2alpha1.CgroupsVolumeName,
+				VolumeSource: corev1.VolumeSource{
+					HostPath: &corev1.HostPathVolumeSource{
+						Path: v2alpha1.CgroupsHostPath,
+					},
+				},
+			},
 			{
 				Name: v2alpha1.SystemProbeSocketVolumeName,
 				VolumeSource: corev1.VolumeSource{