-
Notifications
You must be signed in to change notification settings - Fork 110
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add DatadogPodAutoscaler resource #1118
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This pull request does not contain a valid label. Please add one of the following labels: bug, enhancement, refactoring, documentation, tooling, dependencies
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1118 +/- ##
=======================================
Coverage 54.98% 54.98%
=======================================
Files 243 244 +1
Lines 28031 28033 +2
=======================================
+ Hits 15412 15414 +2
Misses 11747 11747
Partials 872 872
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report in Codecov by Sentry.
|
4a51d76
to
fa26030
Compare
ffd860c
to
286b475
Compare
286b475
to
949a7fb
Compare
3bc1a3c
to
2e93e67
Compare
e5d51c3
to
ec4f0a8
Compare
4caf4d5
to
8c696ed
Compare
e0648ef
to
e83dd78
Compare
8e1114a
to
4ee3369
Compare
4ee3369
to
fe86c22
Compare
7110d8c
to
fe4f933
Compare
fe4f933
to
ad7c41f
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
approved, but why is the skip qa label added? IMO we should QA it for the release
We do have a dedicated QA for Autoscaling, no worries on that and there's no code in the operator to actually QA, everything is in DCA |
@vboulineau OK thanks. |
What does this PR do?
Add
DatadogPodAutoscaler
CRD.Motivation
Product.
Additional Notes
Minimum Agent Versions
Are there minimum versions of the Datadog Agent and/or Cluster Agent required?
Describe your test plan
Checklist
bug
,enhancement
,refactoring
,documentation
,tooling
, and/ordependencies
qa/skip-qa
label