Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add JSON Schema generation for V1 CRDs #1148

Merged
merged 2 commits into from
Nov 20, 2024
Merged

Conversation

vboulineau
Copy link
Contributor

What does this PR do?

Add JSON Schema generation with a dedicated script to CRDs V1.

Motivation

Requirement of having standalone JSON Schema for future developments.

Additional Notes

Minimum Agent Versions

Describe your test plan

Checklist

  • PR has at least one valid label: bug, enhancement, refactoring, documentation, tooling, and/or dependencies
  • PR has a milestone or the qa/skip-qa label

@vboulineau vboulineau force-pushed the vboulineau/json-schema branch 2 times, most recently from 3aa9e43 to 80e9829 Compare April 30, 2024 16:14
@vboulineau vboulineau force-pushed the vboulineau/json-schema branch from 80e9829 to cace912 Compare August 20, 2024 17:48
@codecov-commenter
Copy link

codecov-commenter commented Aug 20, 2024

Codecov Report

Attention: Patch coverage is 0% with 88 lines in your changes missing coverage. Please review.

Project coverage is 48.67%. Comparing base (9b7e09b) to head (bc66485).

Files with missing lines Patch % Lines
hack/jsonschema/openapi2jsonschema.go 0.00% 88 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1148      +/-   ##
==========================================
- Coverage   48.88%   48.67%   -0.22%     
==========================================
  Files         226      227       +1     
  Lines       20147    20235      +88     
==========================================
  Hits         9849     9849              
- Misses       9783     9871      +88     
  Partials      515      515              
Flag Coverage Δ
unittests 48.67% <0.00%> (-0.22%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
hack/generate-docs/generate-docs.go 0.00% <ø> (ø)
hack/jsonschema/openapi2jsonschema.go 0.00% <0.00%> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9b7e09b...bc66485. Read the comment docs.

---- 🚨 Try these New Features:

@vboulineau vboulineau force-pushed the vboulineau/json-schema branch 2 times, most recently from 1b7da63 to 6400d0a Compare November 19, 2024 23:25
@vboulineau
Copy link
Contributor Author

/merge

@dd-devflow
Copy link

dd-devflow bot commented Nov 20, 2024

Devflow running: /merge

View all feedbacks in Devflow UI.


2024-11-20 15:57:50 UTC ℹ️ MergeQueue: waiting for PR to be ready

This merge request is not mergeable yet, because of pending checks/missing approvals. It will be added to the queue as soon as checks pass and/or get approvals.
Note: if you pushed new commits since the last approval, you may need additional approval.
You can remove it from the waiting list with /remove command.


2024-11-20 19:21:17 UTC ℹ️ MergeQueue: merge request added to the queue

The median merge time in main is 15m.

@vboulineau vboulineau force-pushed the vboulineau/json-schema branch from fa83320 to 8361b24 Compare November 20, 2024 17:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants