Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Combine DS cleanup methods (#1100) #1153

Merged
merged 1 commit into from
Apr 25, 2024
Merged

Conversation

fanny-jiang
Copy link
Contributor

What does this PR do?

Cherry-pick #1100

Motivation

What inspired you to submit this pull request?

Additional Notes

Anything else we should know when reviewing?

Minimum Agent Versions

Are there minimum versions of the Datadog Agent and/or Cluster Agent required?

  • Agent: vX.Y.Z
  • Cluster Agent: vX.Y.Z

Describe your test plan

Write there any instructions and details you may have to test your PR.

Checklist

  • PR has at least one valid label: bug, enhancement, refactoring, documentation, tooling, and/or dependencies
  • PR has a milestone or the qa/skip-qa label

(cherry picked from commit 472ff24)
@fanny-jiang fanny-jiang added the enhancement New feature or request label Apr 25, 2024
@fanny-jiang fanny-jiang added this to the v1.6.0 milestone Apr 25, 2024
@fanny-jiang fanny-jiang requested review from a team as code owners April 25, 2024 17:22
@codecov-commenter
Copy link

codecov-commenter commented Apr 25, 2024

Codecov Report

Attention: Patch coverage is 75.83333% with 29 lines in your changes are missing coverage. Please review.

Project coverage is 59.55%. Comparing base (3288792) to head (24a2b72).

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             v1.6    #1153      +/-   ##
==========================================
+ Coverage   59.22%   59.55%   +0.33%     
==========================================
  Files         174      174              
  Lines       21498    21493       -5     
==========================================
+ Hits        12732    12801      +69     
+ Misses       7999     7924      -75     
- Partials      767      768       +1     
Flag Coverage Δ
unittests 59.55% <75.83%> (+0.33%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
...ontrollers/datadogagent/controller_reconcile_v2.go 50.00% <20.00%> (+0.26%) ⬆️
...rollers/datadogagent/controller_reconcile_agent.go 50.70% <78.26%> (+19.78%) ⬆️

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3288792...24a2b72. Read the comment docs.

@fanny-jiang fanny-jiang merged commit 3852747 into v1.6 Apr 25, 2024
18 checks passed
@fanny-jiang fanny-jiang deleted the fanny/cherry-pick-1100 branch April 25, 2024 17:39
@fanny-jiang fanny-jiang removed this from the v1.6.0 milestone Apr 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants