Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add limitranges and storageclasses rbacs to orch explorer feature #1166

Merged
merged 1 commit into from
May 3, 2024

Conversation

celenechang
Copy link
Contributor

What does this PR do?

Follow up to #1159

Motivation

What inspired you to submit this pull request?

Additional Notes

Anything else we should know when reviewing?

Minimum Agent Versions

Are there minimum versions of the Datadog Agent and/or Cluster Agent required?

  • Agent: vX.Y.Z
  • Cluster Agent: vX.Y.Z

Describe your test plan

Write there any instructions and details you may have to test your PR.

Checklist

  • PR has at least one valid label: bug, enhancement, refactoring, documentation, tooling, and/or dependencies
  • PR has a milestone or the qa/skip-qa label

@celenechang celenechang added the enhancement New feature or request label May 3, 2024
@celenechang celenechang added this to the v1.6.0 milestone May 3, 2024
@celenechang celenechang requested review from a team as code owners May 3, 2024 13:36
@codecov-commenter
Copy link

codecov-commenter commented May 3, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 59.55%. Comparing base (77d0df8) to head (afec5d6).

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1166      +/-   ##
==========================================
- Coverage   59.56%   59.55%   -0.02%     
==========================================
  Files         174      174              
  Lines       21565    21559       -6     
==========================================
- Hits        12845    12839       -6     
  Misses       7941     7941              
  Partials      779      779              
Flag Coverage Δ
unittests 59.55% <100.00%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
.../datadogagent/feature/orchestratorexplorer/rbac.go 91.81% <100.00%> (-0.43%) ⬇️

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 77d0df8...afec5d6. Read the comment docs.

@celenechang celenechang merged commit 6b0c7bd into main May 3, 2024
21 checks passed
@celenechang celenechang deleted the celene/orch_rbacs branch May 3, 2024 13:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants