Add cluster name to all v2alpha examples #1172
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adding cluster name to all example files, as it is required for our Kubernetes explorer page to function properly
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1172 +/- ##
=======================================
Coverage 59.55% 59.55%
=======================================
Files 174 174
Lines 21559 21559
=======================================
Hits 12839 12839
Misses 7941 7941
Partials 779 779
Flags with carried forward coverage won't be shown. Click here to find out more. Continue to review full report in Codecov by Sentry.
|
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
|
thank you @dogeahill |
celenechang
approved these changes
May 16, 2024
celenechang
added
documentation
mftoure
pushed a commit
that referenced
this pull request
Oct 3, 2024
* Update datadog-agent-minimum.yaml Adding cluster name to all example files, as it is required for our Kubernetes explorer page to function properly * Update datadog-agent-all.yaml * Update datadog-agent-on-openshift.yaml * Update datadog-agent-with-apm-hostport.yaml * Update datadog-agent-with-clusteragent.yaml * Update datadog-agent-with-dca-clusterchecksrunner.yaml * Update datadog-agent-with-extraconfd.yaml * Update datadog-agent-with-dca-with-orchestrator-explorer.yaml * Update datadog-agent-with-logs-apm.yaml * Update datadog-agent-with-secret-backend.yaml * Update datadog-agent-with-remote-configuration.yaml * Update datadog-agent-with-unix-socket.yaml * Update datadog-agent-with-tolerations.yaml * Update datadog-agent-with-secret-keys.yaml * Update datadog-agent-with-otlp.yaml
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Add clusterName to all v2alpha examples.
Motivation
While implementing on Azure Redhat OpenShift, we used the example and had to add clusterName to properly view the data in our Kubernetes Overview page.
It is a known issue that without the clusterName, the Kubernetes explorer will not be useful as nothing will show besides the container view.
Additional Notes
Anything else we should know when reviewing?
Minimum Agent Versions
Are there minimum versions of the Datadog Agent and/or Cluster Agent required?
Describe your test plan
Write there any instructions and details you may have to test your PR.
Checklist
bug,enhancement,refactoring,documentation,tooling, and/ordependenciesqa/skip-qalabel