Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[bundle] add openmetrics check annotation #1174

Merged
merged 1 commit into from
May 13, 2024

Conversation

celenechang
Copy link
Contributor

What does this PR do?

Add annotation to configure Openmetrics check on Datadog Operator pod when deployed with OLM.

Motivation

What inspired you to submit this pull request?

Additional Notes

Anything else we should know when reviewing?

Minimum Agent Versions

Are there minimum versions of the Datadog Agent and/or Cluster Agent required?

  • Agent: vX.Y.Z
  • Cluster Agent: vX.Y.Z

Describe your test plan

Deploy Datadog Operator with OLM
Deploy a minimal DatadogAgent manifest
Check the agent status output that datadog.operator.* metrics are being collected
Check the web app to confirm metrics are reporting

Checklist

  • PR has at least one valid label: bug, enhancement, refactoring, documentation, tooling, and/or dependencies
  • PR has a milestone or the qa/skip-qa label

@celenechang celenechang added enhancement New feature or request component/olm labels May 9, 2024
@celenechang celenechang added this to the v1.7.0 milestone May 9, 2024
@celenechang celenechang requested review from a team as code owners May 9, 2024 18:37
@codecov-commenter
Copy link

codecov-commenter commented May 9, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 59.55%. Comparing base (6b0c7bd) to head (eaac9b4).

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #1174   +/-   ##
=======================================
  Coverage   59.55%   59.55%           
=======================================
  Files         174      174           
  Lines       21559    21559           
=======================================
  Hits        12839    12839           
  Misses       7941     7941           
  Partials      779      779           
Flag Coverage Δ
unittests 59.55% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6b0c7bd...eaac9b4. Read the comment docs.

@celenechang celenechang merged commit 46c2907 into main May 13, 2024
23 checks passed
@celenechang celenechang deleted the celene/openmetrics_bundle branch May 13, 2024 11:34
mftoure pushed a commit that referenced this pull request Oct 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component/olm enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants