Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove deprecated v2alpha1 flag #1189

Merged
merged 2 commits into from
May 16, 2024
Merged

remove deprecated v2alpha1 flag #1189

merged 2 commits into from
May 16, 2024

Conversation

celenechang
Copy link
Contributor

What does this PR do?

Remove deprecated flag.

In a subsequent PR, references to V2Enabled will be removed.

Motivation

What inspired you to submit this pull request?

Additional Notes

Anything else we should know when reviewing?

Minimum Agent Versions

Are there minimum versions of the Datadog Agent and/or Cluster Agent required?

  • Agent: vX.Y.Z
  • Cluster Agent: vX.Y.Z

Describe your test plan

Ensure v2alpha1 DatadogAgent CR reconciles as expected.

Checklist

  • PR has at least one valid label: bug, enhancement, refactoring, documentation, tooling, and/or dependencies
  • PR has a milestone or the qa/skip-qa label

@celenechang celenechang added the enhancement New feature or request label May 16, 2024
@celenechang celenechang added this to the v1.7.0 milestone May 16, 2024
@celenechang celenechang requested review from a team as code owners May 16, 2024 17:53
main.go Show resolved Hide resolved
@codecov-commenter
Copy link

codecov-commenter commented May 16, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 59.54%. Comparing base (ef9a40c) to head (1cf2d4c).
Report is 2 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #1189   +/-   ##
=======================================
  Coverage   59.54%   59.54%           
=======================================
  Files         174      174           
  Lines       21598    21598           
=======================================
  Hits        12861    12861           
  Misses       7958     7958           
  Partials      779      779           
Flag Coverage Δ
unittests 59.54% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ef9a40c...1cf2d4c. Read the comment docs.

@celenechang celenechang merged commit 0b47ddc into main May 16, 2024
19 checks passed
@celenechang celenechang deleted the celene/rm_v2_flag branch May 16, 2024 19:51
mftoure pushed a commit that referenced this pull request Oct 3, 2024
* remove deprecated v2alpha1 flag

* add modified warning with webhookEnabled flag
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants