Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove XValidation rule in DPA as requires K8S >= 1.25 #1339

Merged
merged 1 commit into from
Aug 1, 2024

Conversation

vboulineau
Copy link
Contributor

What does this PR do?

Remove XValidation rule in DPA as requires K8S >= 1.25

Motivation

Bugfix.

Additional Notes

Anything else we should know when reviewing?

Minimum Agent Versions

Are there minimum versions of the Datadog Agent and/or Cluster Agent required?

  • Agent: vX.Y.Z
  • Cluster Agent: vX.Y.Z

Describe your test plan

Write there any instructions and details you may have to test your PR.

Checklist

  • PR has at least one valid label: bug, enhancement, refactoring, documentation, tooling, and/or dependencies
  • PR has a milestone or the qa/skip-qa label

@vboulineau vboulineau added bug Something isn't working qa/skip-qa labels Aug 1, 2024
@vboulineau vboulineau added this to the v1.8.0 milestone Aug 1, 2024
@vboulineau vboulineau requested a review from a team as a code owner August 1, 2024 19:54
@codecov-commenter
Copy link

codecov-commenter commented Aug 1, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 47.51%. Comparing base (ca6ce6c) to head (9c7d5ad).
Report is 23 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #1339   +/-   ##
=======================================
  Coverage   47.51%   47.51%           
=======================================
  Files         230      230           
  Lines       22040    22040           
=======================================
  Hits        10472    10472           
  Misses      10976    10976           
  Partials      592      592           
Flag Coverage Δ
unittests 47.51% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
...s/datadoghq/v1alpha1/datadogpodautoscaler_types.go 100.00% <ø> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ca6ce6c...9c7d5ad. Read the comment docs.

@fanny-jiang fanny-jiang merged commit 063fd61 into main Aug 1, 2024
23 checks passed
@fanny-jiang fanny-jiang deleted the vboulineau/fix-crd branch August 1, 2024 22:42
levan-m added a commit that referenced this pull request Aug 9, 2024
Co-authored-by: Vincent Boulineau <58430298+vboulineau@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working qa/skip-qa
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants