Migrate to kubebuilder v4 #1355
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
…e-kustomize # Conflicts: # api/datadoghq/v1alpha1/datadogagent_conversion.go # api/datadoghq/v1alpha1/datadogagent_conversion_agent.go # api/datadoghq/v1alpha1/datadogagent_conversion_ccr.go # api/datadoghq/v1alpha1/datadogagent_conversion_dca.go # api/datadoghq/v1alpha1/datadogagent_conversion_test.go # api/datadoghq/v1alpha1/datadogagent_default.go # api/datadoghq/v1alpha1/datadogagent_default_test.go # api/datadoghq/v1alpha1/datadogagent_types.go # api/datadoghq/v1alpha1/datadogagent_validation.go # api/datadoghq/v1alpha1/patch/datadogagent.go # api/datadoghq/v1alpha1/patch/datadogagent_test.go # api/datadoghq/v1alpha1/secret.go # api/datadoghq/v1alpha1/test/new.go # api/datadoghq/v1alpha1/testdata/all.expected.yaml # api/datadoghq/v1alpha1/testdata/all.yaml # api/datadoghq/v1alpha1/testdata/empty.expected.yaml # api/datadoghq/v1alpha1/testdata/empty.yaml # api/datadoghq/v1alpha1/testdata/featureOvr.expected.yaml # api/datadoghq/v1alpha1/testdata/featureOvr.yaml # api/datadoghq/v1alpha1/utils.go # api/datadoghq/v1alpha1/utils_test.go # api/datadoghq/v1alpha1/zz_generated.deepcopy.go # api/datadoghq/v1alpha1/zz_generated.openapi.go # cmd/check-operator/upgrade/upgrade.go # cmd/kubectl-datadog/agent/upgrade/upgrade.go # cmd/kubectl-datadog/agent/upgrade/upgrade_test.go # cmd/kubectl-datadog/clusteragent/upgrade/upgrade.go # cmd/kubectl-datadog/clusteragent/upgrade/upgrade_test.go # cmd/kubectl-datadog/flare/flare.go # cmd/kubectl-datadog/get/get.go # internal/controller/testutils/new.go # pkg/controller/utils/condition/condition.go # pkg/plugin/common/statuswrapper.go # pkg/plugin/common/v2support.go
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1355 +/- ##
=======================================
Coverage 47.40% 47.40%
=======================================
Files 223 223
Lines 19244 19244
=======================================
Hits 9123 9123
Misses 9635 9635
Partials 486 486
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 8 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
…e-kustomize # Conflicts: # internal/controller/datadogagent/feature/apm/feature.go # internal/controller/datadogagent/feature/apm/feature_test.go
levan-m
approved these changes
Aug 29, 2024
# Conflicts: # api/datadoghq/v2alpha1/zz_generated.openapi.go # internal/controller/datadogagent/override/daemonset_test.go # pkg/agentprofile/agent_profile_test.go
fanny-jiang
force-pushed
the
fanny/CECO-1269/update-kustomize
branch
from
8ad0a4d to
254c832
Compare
levan-m
approved these changes
Sep 4, 2024
mftoure
pushed a commit
that referenced
this pull request
Oct 3, 2024
* update licenses * migrate project to kubebuilder v4 * post-merge fixes * fix licenses * fix check-operator dockerfile * migrate deprecated kustomization fields * comment out v1alpha1 resources/patches * post-merge fix * fix generated files --------- Co-authored-by: levan-m <116471169+levan-m@users.noreply.github.com> Co-authored-by: Levan Machablishvili <levan.machablishvili@datadoghq.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Migrate project to use kubebuilder v4: https://book.kubebuilder.io/migration/manually_migration_guide_gov3_to_gov4
Main changes:
controllers/renamed and moved tointernal/controller/apis/renamed toapi/main.gomoved tocmd/main.goMotivation
What inspired you to submit this pull request?
Additional Notes
Anything else we should know when reviewing?
Minimum Agent Versions
Are there minimum versions of the Datadog Agent and/or Cluster Agent required?
Describe your test plan
make alland there should be no errors and tests passmake VERSION=X.Y.Z-rc.W LATEST_VERSION=X.Y.Z bundleand check that bundle is created properly and does not produce errors in the terminalmake redhat-bundlemake installin a fresh kind cluster and CRDs should installmake deployand check that the operator pod is running properlyChecklist
bug,enhancement,refactoring,documentation,tooling, and/ordependenciesqa/skip-qalabel