Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[docs] add note about upgrading to 1.8.0 in openshift #1392

Merged
merged 10 commits into from
Sep 6, 2024

Conversation

celenechang
Copy link
Contributor

What does this PR do?

Adds note in our openshift doc about a known issue when upgrading to 1.8.0 in openshift

Motivation

#1389

Additional Notes

Anything else we should know when reviewing?

Minimum Agent Versions

Are there minimum versions of the Datadog Agent and/or Cluster Agent required?

  • Agent: vX.Y.Z
  • Cluster Agent: vX.Y.Z

Describe your test plan

Write there any instructions and details you may have to test your PR.

Checklist

  • PR has at least one valid label: bug, enhancement, refactoring, documentation, tooling, and/or dependencies
  • PR has a milestone or the qa/skip-qa label

@celenechang celenechang added documentation Improvements or additions to documentation qa/skip-qa labels Sep 5, 2024
@celenechang celenechang requested review from a team as code owners September 5, 2024 11:19
@codecov-commenter
Copy link

codecov-commenter commented Sep 5, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 50.48%. Comparing base (ddaac56) to head (b4b2fab).
Report is 4 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1392      +/-   ##
==========================================
+ Coverage   47.14%   50.48%   +3.33%     
==========================================
  Files         217      377     +160     
  Lines       18768    33558   +14790     
==========================================
+ Hits         8849    16943    +8094     
- Misses       9457    15711    +6254     
- Partials      462      904     +442     
Flag Coverage Δ
unittests 50.48% <ø> (+3.33%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 167 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ddaac56...b4b2fab. Read the comment docs.

docs/install-openshift.md Outdated Show resolved Hide resolved
Copy link
Contributor Author

@celenechang celenechang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for the updates! could we restructure it a bit so that it's clearer there are two possible courses of action - one before upgrade and one after the error is viewed?

perhaps a subheader for each, and the bulk of the explanation in the after section

docs/install-openshift.md Outdated Show resolved Hide resolved
docs/install-openshift.md Outdated Show resolved Hide resolved
docs/install-openshift.md Outdated Show resolved Hide resolved
tbavelier and others added 3 commits September 5, 2024 15:06
Co-authored-by: Celene <celene@datadoghq.com>
Co-authored-by: Celene <celene@datadoghq.com>
Co-authored-by: Celene <celene@datadoghq.com>
Copy link
Contributor

@alai97 alai97 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, one suggestion.

docs/install-openshift.md Outdated Show resolved Hide resolved
Co-authored-by: Austin Lai <76412946+alai97@users.noreply.github.com>
Copy link
Member

@tbavelier tbavelier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tbavelier
Copy link
Member

/merge

@dd-devflow
Copy link

dd-devflow bot commented Sep 6, 2024

🚂 MergeQueue: waiting for PR to be ready

This merge request is not mergeable yet, because of pending checks/missing approvals. It will be added to the queue as soon as checks pass and/or get approvals.
Note: if you pushed new commits since the last approval, you may need additional approval.
You can remove it from the waiting list with /remove command.

Use /merge -c to cancel this operation!

@dd-devflow
Copy link

dd-devflow bot commented Sep 6, 2024

🚂 MergeQueue: pull request added to the queue

The median merge time in main is 16m.

Use /merge -c to cancel this operation!

@dd-mergequeue dd-mergequeue bot merged commit 4c40ffd into main Sep 6, 2024
30 checks passed
@dd-mergequeue dd-mergequeue bot deleted the celene/openshift_1.8_doc branch September 6, 2024 07:50
mftoure pushed a commit that referenced this pull request Oct 3, 2024
Co-authored-by: tbavelier <97530782+tbavelier@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation mergequeue-status: done qa/skip-qa
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants