-
Notifications
You must be signed in to change notification settings - Fork 110
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[docs] add note about upgrading to 1.8.0 in openshift #1392
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1392 +/- ##
==========================================
+ Coverage 47.14% 50.48% +3.33%
==========================================
Files 217 377 +160
Lines 18768 33558 +14790
==========================================
+ Hits 8849 16943 +8094
- Misses 9457 15711 +6254
- Partials 462 904 +442
Flags with carried forward coverage won't be shown. Click here to find out more. see 167 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks for the updates! could we restructure it a bit so that it's clearer there are two possible courses of action - one before upgrade and one after the error is viewed?
perhaps a subheader for each, and the bulk of the explanation in the after section
Co-authored-by: Celene <celene@datadoghq.com>
Co-authored-by: Celene <celene@datadoghq.com>
Co-authored-by: Celene <celene@datadoghq.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, one suggestion.
Co-authored-by: Austin Lai <76412946+alai97@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
/merge |
🚂 MergeQueue: waiting for PR to be ready This merge request is not mergeable yet, because of pending checks/missing approvals. It will be added to the queue as soon as checks pass and/or get approvals. Use |
🚂 MergeQueue: pull request added to the queue The median merge time in Use |
Co-authored-by: tbavelier <97530782+tbavelier@users.noreply.github.com>
What does this PR do?
Adds note in our openshift doc about a known issue when upgrading to 1.8.0 in openshift
Motivation
#1389
Additional Notes
Anything else we should know when reviewing?
Minimum Agent Versions
Are there minimum versions of the Datadog Agent and/or Cluster Agent required?
Describe your test plan
Write there any instructions and details you may have to test your PR.
Checklist
bug
,enhancement
,refactoring
,documentation
,tooling
, and/ordependencies
qa/skip-qa
label