[cleanup] reorganize constant files

[celenechang]

What does this PR do?

Move some constant definitions
Provide descriptions of what constant files are used for
A bit of housekeeping, like fixing grammar on descriptions and alphabetizing chunks of constant definitions

Motivation

Cleanup

Additional Notes

Anything else we should know when reviewing?

Minimum Agent Versions

Are there minimum versions of the Datadog Agent and/or Cluster Agent required?

• Agent: vX.Y.Z
• Cluster Agent: vX.Y.Z

Describe your test plan

This change is noop. Can run make build and make test to confirm

Checklist

• PR has at least one valid label: bug, enhancement, refactoring, documentation, tooling, and/or dependencies
• PR has a milestone or the qa/skip-qa label

[codecov-commenter]

Codecov Report

Attention: Patch coverage is 71.42857% with 6 lines in your changes missing coverage. Please review.

Project coverage is 47.40%. Comparing base (4c40ffd) to head (f32c0ee).

Files with missing lines	Patch %	Lines
...ler/datadogagent/controller_reconcile_v2_common.go	33.33%	4 Missing ⚠️
...ontroller/datadogagent/controller_reconcile_ccr.go	0.00%	1 Missing ⚠️
...ontroller/datadogagent/controller_reconcile_dca.go	0.00%	1 Missing ⚠️

Additional details and impacted files

@@           Coverage Diff           @@
##             main    #1399   +/-   ##
=======================================
  Coverage   47.40%   47.40%           
=======================================
  Files         223      223           
  Lines       19244    19244           
=======================================
  Hits         9123     9123           
  Misses       9635     9635           
  Partials      486      486           

Flag	Coverage Δ
unittests	47.40% <71.42%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines	Coverage Δ
...troller/datadogagent/controller_reconcile_agent.go	53.44% <100.00%> (ø)
...l/controller/datadogagent/override/dependencies.go	54.05% <100.00%> (ø)
...ontroller/datadogagent/override/podtemplatespec.go	72.72% <100.00%> (ø)
pkg/kubernetes/const.go	87.50% <100.00%> (ø)
...ontroller/datadogagent/controller_reconcile_ccr.go	47.43% <0.00%> (ø)
...ontroller/datadogagent/controller_reconcile_dca.go	26.37% <0.00%> (ø)
...ler/datadogagent/controller_reconcile_v2_common.go	29.96% <33.33%> (ø)

---

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4c40ffd...f32c0ee. Read the comment docs.

[tbavelier]

Should we consider also adding within the singular RoleBindingKind = "RoleBinding" as it was present previously in internal/controller/datadogagent/const.go, even though it's not used yet ?

[celenechang]

thanks for the review - since we're not using it i'll leave it out, but if we ever do need it in the future it'll be clear where it goes

[tbavelier]

Looking great! One minor comment but LGTM