[CECO-2][DatadogMonitor] Configure force sync period #1404
Conversation
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
| if err != nil { | ||
| logger.Error(err, "Invalid value for monitor force sync period. Defaulting to 60 minutes.") | ||
| } else { | ||
| logger.V(1).Info("Setting monitor force sync period", "minutes", forceSyncPeriodInt) |
There was a problem hiding this comment.
To avoid spamming the used sync period, this log is set to appear only in debug with logger.V(1)
| @@ -71,8 +71,11 @@ To deploy a `DatadogMonitor` with the Datadog Operator, use the [`datadog-operat | |||
| ``` | |||
|
|
|||
| This automatically creates a new monitor in Datadog. You can find it on the [Manage Monitors][7] page of your Datadog account. | |||
|
|
|||
There was a problem hiding this comment.
Adding this break line so the note stands out properly instead of being on the same line:
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1404 +/- ##
==========================================
- Coverage 49.01% 49.01% -0.01%
==========================================
Files 223 223
Lines 19501 19508 +7
==========================================
+ Hits 9559 9562 +3
- Misses 9453 9456 +3
- Partials 489 490 +1
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report in Codecov by Sentry.
|
|
/merge |
|
🚂 MergeQueue: pull request added to the queue The median merge time in Use |
|
/merge |
|
🚂 MergeQueue: pull request added to the queue The median merge time in Use |
What does this PR do?
DD_MONITOR_FORCE_SYNC_PERIODenv varMotivation
Describe your test plan
DD_MONITOR_FORCE_SYNC_PERIODset to5kubectl apply -f examples/datadogmonitor/metric-monitor-imagepullbackoff.yamlDatadogMonitor)DatadogMonitorquery within 5 minutes at most from your modification : you can identify this by looking at the monitor audit trail in the UI or in kubernetes by reviewing theMonitor Last Force Sync Timein theDatadogMonitor(withinStatus) or the associated eventsDD_MONITOR_FORCE_SYNC_PERIODto a non integer value, e.g. "0,5" and assess the presence of the operator log complaining the value is invalid:{"level":"ERROR","ts":"2024-09-11T12:44:03.864Z","logger":"controllers.DatadogMonitor","msg":"Invalid value for monitor force sync period. Defaulting to 60 minutes.","datadogmonitor":{"name":"pods-imagepullbackoff","namespace":"system"},"error":"strconv.Atoi: parsing \"0,5\": invalid syntax"}Checklist
bug,enhancement,refactoring,documentation,tooling, and/ordependenciesqa/skip-qalabel