Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Dashboard] Replace DashboardLastForceSyncTime with LastForceSyncTime #1410

Merged
merged 3 commits into from
Sep 12, 2024

Conversation

tbavelier
Copy link
Member

What does this PR do?

  • Replaces DashboardLastForceSyncTime with LastForceSyncTime

Motivation

  • Removes OpenAPI violation when using make generate
API rule violation: names_match,./api/datadoghq/v1alpha1,DatadogDashboardStatus,LastForceSyncTime

Additional Notes

  • Will be cherry-picked to v1.9

Minimum Agent Versions

Are there minimum versions of the Datadog Agent and/or Cluster Agent required?

  • Agent: vX.Y.Z
  • Cluster Agent: vX.Y.Z

Describe your test plan

  • No Q/A needed, no functional change

Checklist

  • PR has at least one valid label: bug, enhancement, refactoring, documentation, tooling, and/or dependencies
  • PR has a milestone or the qa/skip-qa label

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This pull request does not contain a valid label. Please add one of the following labels: bug, enhancement, refactoring, documentation, tooling, dependencies

@tbavelier tbavelier added the enhancement New feature or request label Sep 12, 2024
@codecov-commenter
Copy link

codecov-commenter commented Sep 12, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 47.40%. Comparing base (6d4bbd9) to head (5e3dbfc).
Report is 1 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #1410   +/-   ##
=======================================
  Coverage   47.40%   47.40%           
=======================================
  Files         223      223           
  Lines       19244    19244           
=======================================
  Hits         9123     9123           
  Misses       9635     9635           
  Partials      486      486           
Flag Coverage Δ
unittests 47.40% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
api/datadoghq/v1alpha1/datadogdashboard_types.go 100.00% <ø> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6d4bbd9...5e3dbfc. Read the comment docs.

tbavelier and others added 2 commits September 12, 2024 16:35
@tbavelier
Copy link
Member Author

/merge

@dd-devflow
Copy link

dd-devflow bot commented Sep 12, 2024

🚂 MergeQueue: pull request added to the queue

The median merge time in main is 15m.

Use /merge -c to cancel this operation!

@dd-mergequeue dd-mergequeue bot merged commit ccf06e1 into main Sep 12, 2024
26 checks passed
@dd-mergequeue dd-mergequeue bot deleted the tbavelier/fix_openapi_warning_dashboard_crd branch September 12, 2024 15:10
@khewonc khewonc modified the milestones: v1.10.0, v1.9.0 Sep 12, 2024
mftoure pushed a commit that referenced this pull request Oct 3, 2024
…#1410)

* Replace DashboardLastForceSyncTime with LastForceSyncTime to remove warning

* Datadogdashboard -> DatadogDashboard

Co-authored-by: Celene <celene@datadoghq.com>

* re-generate after review comment

---------

Co-authored-by: Celene <celene@datadoghq.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants