Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove capitalization for profile field #1423

Merged
merged 1 commit into from
Sep 17, 2024
Merged

Conversation

khewonc
Copy link
Contributor

@khewonc khewonc commented Sep 17, 2024

What does this PR do?

Remove capitalization for createStrategy

Motivation

What inspired you to submit this pull request?

Additional Notes

Anything else we should know when reviewing?

Minimum Agent Versions

Are there minimum versions of the Datadog Agent and/or Cluster Agent required?

  • Agent: vX.Y.Z
  • Cluster Agent: vX.Y.Z

Describe your test plan

Check the crd for createStrategy and not CreateStrategy

Checklist

  • PR has at least one valid label: bug, enhancement, refactoring, documentation, tooling, and/or dependencies
  • PR has a milestone or the qa/skip-qa label

@khewonc khewonc added the bug Something isn't working label Sep 17, 2024
@khewonc khewonc added this to the v1.9.0 milestone Sep 17, 2024
@khewonc khewonc requested a review from a team as a code owner September 17, 2024 20:37
@codecov-commenter
Copy link

codecov-commenter commented Sep 17, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 49.00%. Comparing base (69ef43b) to head (e0ecc61).

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #1423   +/-   ##
=======================================
  Coverage   49.00%   49.00%           
=======================================
  Files         223      223           
  Lines       19268    19268           
=======================================
  Hits         9442     9442           
  Misses       9343     9343           
  Partials      483      483           
Flag Coverage Δ
unittests 49.00% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
...pi/datadoghq/v1alpha1/datadogagentprofile_types.go 100.00% <ø> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 69ef43b...e0ecc61. Read the comment docs.

@khewonc khewonc merged commit 35d3799 into main Sep 17, 2024
21 checks passed
@khewonc khewonc deleted the khewonc/dap-crd-capitalisation branch September 17, 2024 21:05
khewonc added a commit that referenced this pull request Sep 24, 2024
mftoure pushed a commit that referenced this pull request Oct 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants