Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[cleanup] shuffle constants in pkg/config #1426

Merged
merged 1 commit into from
Sep 23, 2024

Conversation

celenechang
Copy link
Contributor

@celenechang celenechang commented Sep 23, 2024

What does this PR do?

A small cleanup-related change for constants defined in pkg/config . Remove duplicate envvars and move one envvar to apicommon

Also, incorporate DD_DD_URL envvar option into datadog client setup

Motivation

What inspired you to submit this pull request?

Additional Notes

Anything else we should know when reviewing?

Minimum Agent Versions

Are there minimum versions of the Datadog Agent and/or Cluster Agent required?

  • Agent: vX.Y.Z
  • Cluster Agent: vX.Y.Z

Describe your test plan

Make sure operator builds and runs as expected

Checklist

  • PR has at least one valid label: bug, enhancement, refactoring, documentation, tooling, and/or dependencies
  • PR has a milestone or the qa/skip-qa label

@celenechang celenechang added this to the v1.10.0 milestone Sep 23, 2024
@celenechang celenechang requested a review from a team as a code owner September 23, 2024 12:37
@codecov-commenter
Copy link

codecov-commenter commented Sep 23, 2024

Codecov Report

Attention: Patch coverage is 33.33333% with 4 lines in your changes missing coverage. Please review.

Project coverage is 48.94%. Comparing base (909a576) to head (05379be).

Files with missing lines Patch % Lines
pkg/datadogclient/client.go 0.00% 4 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1426      +/-   ##
==========================================
- Coverage   48.94%   48.94%   -0.01%     
==========================================
  Files         221      221              
  Lines       19246    19248       +2     
==========================================
  Hits         9420     9420              
- Misses       9343     9345       +2     
  Partials      483      483              
Flag Coverage Δ
unittests 48.94% <33.33%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
pkg/config/config.go 67.92% <ø> (ø)
pkg/config/creds.go 100.00% <100.00%> (ø)
pkg/datadogclient/client.go 0.00% <0.00%> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 909a576...05379be. Read the comment docs.

@celenechang celenechang merged commit 3c38ef2 into main Sep 23, 2024
21 checks passed
@celenechang celenechang deleted the celene/pkg_config_cleanup branch September 23, 2024 17:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants