-
Notifications
You must be signed in to change notification settings - Fork 109
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Consolidate versionInfo and platformInfo #1436
Merged
khewonc
merged 21 commits into
main
from
mrmcpat-consolidate-versioninfo-and-platforminfo
Oct 3, 2024
Merged
Consolidate versionInfo and platformInfo #1436
khewonc
merged 21 commits into
main
from
mrmcpat-consolidate-versioninfo-and-platforminfo
Oct 3, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This pull request does not contain a valid label. Please add one of the following labels: bug, enhancement, refactoring, documentation, tooling, dependencies
mrdoggopat
changed the title
consolidate versionInfo and platformInfo
Consolidate versionInfo and platformInfo
Sep 24, 2024
remove commented versionInfo
remove commented versionInfo
remove commented versionInfo
remove commented versionInfo
remove commented versionInfo
khewonc
reviewed
Sep 26, 2024
internal/controller/datadogagent/feature/externalmetrics/feature.go
Outdated
Show resolved
Hide resolved
khewonc
reviewed
Sep 26, 2024
Co-authored-by: khewonc <39867936+khewonc@users.noreply.github.com>
Co-authored-by: khewonc <39867936+khewonc@users.noreply.github.com>
khewonc
reviewed
Sep 30, 2024
khewonc
approved these changes
Oct 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Cleanup the unused versionInfo and consolidate this to kubernetes.platformInfo. version.Info is duplicated in the store since kubernetes.platformInfo contains the same version.Info.
A brief description of the change being made with this pull request.
CECO-415
What inspired you to submit this pull request?
N/A
Anything else we should know when reviewing?
N/A
Are there minimum versions of the Datadog Agent and/or Cluster Agent required?
N/A
Describe your test plan
Write there any instructions and details you may have to test your PR.
Spin up a k8s cluster below and above version 1.22.
Check if the ShouldCreateAgentLocalService function (https://github.com/DataDog/datadog-operator/blob/main/internal/controller/datadogagent/common/utils.go#L128-L134) works the same way after the change:
Checklist
bug
,enhancement
,refactoring
,documentation
,tooling
, and/ordependencies
qa/skip-qa
label