[BARX-512] Set Registry to Azure if site is us3 #1438
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1438 +/- ##
=======================================
Coverage 48.94% 48.95%
=======================================
Files 221 221
Lines 19250 19252 +2
=======================================
+ Hits 9422 9424 +2
Misses 9345 9345
Partials 483 483
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report in Codecov by Sentry.
|
jhgilbert
approved these changes
Sep 25, 2024
tbavelier
approved these changes
Oct 1, 2024
There was a problem hiding this comment.
LGTM, could you simply update the PR description with the QA instructions, something like:
"Create a DatadogAgent with site set to us3.datadoghq.com, the registry should be defaulted to azure one, verify the images that are pulled from said registry datadoghq.azurecr.io"
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR sets the registry to Azure if the site used is us3. Implemented in helm: DataDog/helm-charts#1537
Motivation
Azure users can benefit from the ACR.
Additional Notes
N/A
Minimum Agent Versions
N/A
Describe your test plan
Create a DatadogAgent with site set to us3.datadoghq.com, the registry should be defaulted to azure one, verify the images that are pulled from said registry datadoghq.azurecr.io
Checklist
bug,enhancement,refactoring,documentation,tooling, and/ordependenciesqa/skip-qalabel