[cleanup] move constants to feature-specific files #1444
Conversation
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
| InstallInfoVolumeSubPath = "install_info" | ||
| InstallInfoVolumePath = "/etc/datadog-agent/install_info" | ||
| InstallInfoVolumeReadOnly = true | ||
|
|
||
| DogstatsdHostPortName = "dogstatsdport" |
There was a problem hiding this comment.
Should some of the dogstatsd constants be moved to the feature's const file? DogstatsdHostPortName is only used in dsd's feature.go and test file, but some others are used elsewhere
There was a problem hiding this comment.
yea, i intentionally punted on the ones that require some thought, for now..
| @@ -24,7 +24,7 @@ const ( | |||
| defaultLogContainerLogsPath string = "/var/lib/docker/containers" | |||
| defaultLogPodLogsPath string = "/var/log/pods" | |||
| defaultLogContainerSymlinksPath string = "/var/log/containers" | |||
| defaultLogTempStoragePath string = "/var/lib/datadog-agent/logs" | |||
| DefaultLogTempStoragePath string = "/var/lib/datadog-agent/logs" | |||
There was a problem hiding this comment.
Should this go in api/datadoghq/common/const.go?
There was a problem hiding this comment.
i think you're right that it would be a better place for it
|
|
||
| apmHostPortName = "traceport" | ||
| apmSocketVolumeName = "apmsocket" | ||
| apmSocketVolumeLocalPath = "/var/run/datadog" |
There was a problem hiding this comment.
Should this be combined with dsd like we do with the hostpath DogstatsdAPMSocketHostPath? Or would it be better to separate DogstatsdAPMSocketHostPath into dsd and apm specific paths?
There was a problem hiding this comment.
i'm not sure, but i guess we can decide and stick with one approach. it certainly seems there is some deduplication we can do for this particular constant
What does this PR do?
Move feature-specific constants from api/common to be near where they are used
Motivation
What inspired you to submit this pull request?
Additional Notes
Anything else we should know when reviewing?
Minimum Agent Versions
Are there minimum versions of the Datadog Agent and/or Cluster Agent required?
Describe your test plan
Ensure the change is noop, i.e. the binary builds and runs without issue
Checklist
bug,enhancement,refactoring,documentation,tooling, and/ordependenciesqa/skip-qalabel