Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[gitlab] fix conditional to run release candidate workflow #1462

Merged
merged 2 commits into from
Oct 11, 2024

Conversation

celenechang
Copy link
Contributor

What does this PR do?

Fix conditional noticed because the job didn't run when expected

Motivation

What inspired you to submit this pull request?

Additional Notes

Anything else we should know when reviewing?

Minimum Agent Versions

Are there minimum versions of the Datadog Agent and/or Cluster Agent required?

  • Agent: vX.Y.Z
  • Cluster Agent: vX.Y.Z

Describe your test plan

Write there any instructions and details you may have to test your PR.

Checklist

  • PR has at least one valid label: bug, enhancement, refactoring, documentation, tooling, and/or dependencies
  • PR has a milestone or the qa/skip-qa label

@codecov-commenter
Copy link

codecov-commenter commented Oct 11, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 49.22%. Comparing base (26068ba) to head (4d88fa0).

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #1462   +/-   ##
=======================================
  Coverage   49.22%   49.22%           
=======================================
  Files         224      224           
  Lines       19700    19700           
=======================================
  Hits         9697     9697           
  Misses       9497     9497           
  Partials      506      506           
Flag Coverage Δ
unittests 49.22% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 26068ba...4d88fa0. Read the comment docs.

@celenechang celenechang merged commit 713978f into main Oct 11, 2024
19 checks passed
@celenechang celenechang deleted the celene/fix_rc_gitlab branch October 11, 2024 12:25
celenechang added a commit that referenced this pull request Oct 24, 2024
* [gitlab] fix condition to run release candidate workflow (#1462)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants