Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not log error if sync variable is not set (#1466) #1469

Merged
merged 1 commit into from
Oct 17, 2024

Conversation

tbavelier
Copy link
Member

What does this PR do?

Cherry-pick 427385c from #1466

Motivation

Refer to original PR, uncovered during QA

Additional Notes

Anything else we should know when reviewing?

Minimum Agent Versions

Are there minimum versions of the Datadog Agent and/or Cluster Agent required?

  • Agent: vX.Y.Z
  • Cluster Agent: vX.Y.Z

Describe your test plan

Checklist

  • PR has at least one valid label: bug, enhancement, refactoring, documentation, tooling, and/or dependencies
  • PR has a milestone or the qa/skip-qa label

@tbavelier tbavelier added the bug Something isn't working label Oct 17, 2024
@tbavelier tbavelier added this to the v1.10.0 milestone Oct 17, 2024
@tbavelier tbavelier requested a review from a team as a code owner October 17, 2024 07:54
@codecov-commenter
Copy link

codecov-commenter commented Oct 17, 2024

Codecov Report

Attention: Patch coverage is 11.11111% with 8 lines in your changes missing coverage. Please review.

Project coverage is 49.20%. Comparing base (648b7c7) to head (ae63fde).

Files with missing lines Patch % Lines
internal/controller/datadogmonitor/controller.go 11.11% 7 Missing and 1 partial ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##            v1.10    #1469      +/-   ##
==========================================
- Coverage   49.22%   49.20%   -0.02%     
==========================================
  Files         224      224              
  Lines       19700    19701       +1     
==========================================
- Hits         9697     9694       -3     
- Misses       9497     9501       +4     
  Partials      506      506              
Flag Coverage Δ
unittests 49.20% <11.11%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
internal/controller/datadogmonitor/controller.go 46.69% <11.11%> (-1.36%) ⬇️

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 648b7c7...ae63fde. Read the comment docs.

@tbavelier
Copy link
Member Author

/merge

@dd-devflow
Copy link

dd-devflow bot commented Oct 17, 2024

🚂 MergeQueue: pull request added to the queue

The median merge time in v1.10 is 0s.

Use /merge -c to cancel this operation!

@dd-mergequeue dd-mergequeue bot merged commit 59191c6 into v1.10 Oct 17, 2024
25 checks passed
@dd-mergequeue dd-mergequeue bot deleted the tbavelier/cherry_pick_1466 branch October 17, 2024 12:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working mergequeue-status: done
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants