Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement label and annotation equality checking (#1467) #1470

Merged
merged 1 commit into from
Oct 17, 2024

Conversation

khewonc
Copy link
Contributor

@khewonc khewonc commented Oct 17, 2024

  • Implement label and annotation equality checking

  • Update pkg/equality/equality_test.go


What does this PR do?

Cherry pick #1467

Motivation

What inspired you to submit this pull request?

Additional Notes

Anything else we should know when reviewing?

Minimum Agent Versions

Are there minimum versions of the Datadog Agent and/or Cluster Agent required?

  • Agent: vX.Y.Z
  • Cluster Agent: vX.Y.Z

Describe your test plan

Write there any instructions and details you may have to test your PR.

Checklist

  • PR has at least one valid label: bug, enhancement, refactoring, documentation, tooling, and/or dependencies
  • PR has a milestone or the qa/skip-qa label

* Implement label and annotation equality checking

* Update pkg/equality/equality_test.go

Co-authored-by: Timothée Bavelier <97530782+tbavelier@users.noreply.github.com>

---------

Co-authored-by: Timothée Bavelier <97530782+tbavelier@users.noreply.github.com>
@khewonc khewonc added bug Something isn't working enhancement New feature or request qa/skip-qa labels Oct 17, 2024
@khewonc khewonc added this to the v1.10.0 milestone Oct 17, 2024
@khewonc khewonc requested a review from a team as a code owner October 17, 2024 14:25
@codecov-commenter
Copy link

codecov-commenter commented Oct 17, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 49.12%. Comparing base (59191c6) to head (1fefac4).

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##            v1.10    #1470      +/-   ##
==========================================
- Coverage   49.20%   49.12%   -0.08%     
==========================================
  Files         224      224              
  Lines       19701    19699       -2     
==========================================
- Hits         9694     9678      -16     
- Misses       9501     9518      +17     
+ Partials      506      503       -3     
Flag Coverage Δ
unittests 49.12% <100.00%> (-0.08%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
pkg/equality/equality.go 2.35% <100.00%> (-9.28%) ⬇️

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 59191c6...1fefac4. Read the comment docs.

@khewonc khewonc merged commit 516d191 into v1.10 Oct 17, 2024
22 checks passed
@khewonc khewonc deleted the khewonc/cherry-pick-1467 branch October 17, 2024 14:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working enhancement New feature or request qa/skip-qa
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants